Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish translation - admin #132

Merged
merged 5 commits into from
Aug 25, 2018
Merged

Polish translation - admin #132

merged 5 commits into from
Aug 25, 2018

Conversation

vavepl
Copy link
Contributor

@vavepl vavepl commented Aug 24, 2018

No description provided.

@coveralls
Copy link

coveralls commented Aug 24, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 20.781% when pulling 59ba00e on vavepl:patch-2 into eb3d33d on luyadev:master.

@nadar
Copy link
Member

nadar commented Aug 25, 2018

@vavepl the unit test reported an exception, please take a look:

  1. cmstests\src\MessageFileTest::testFrontendMessages
    The language key 'block_module_moduleactionargs_label' does not exists in the language file '/home/travis/build/luyadev/luya-module-cms/src/frontend/messages/pl/cms.php'.
    Failed asserting that an array has the key 'block_module_moduleactionargs_label'.

Could also please add a changelog entry?

@nadar nadar self-requested a review August 25, 2018 08:42
@nadar nadar merged commit f66a9f2 into luyadev:master Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadar nadar Awaiting requested review from nadar

Assignees

@nadar nadar

@vavepl vavepl

Labels
translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vavepl @coveralls @nadar