Adds capability to avoid passing unseen levels to rare #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @TommyMatthews! Please run the pre-commit hook to hopefully autofix the linting failures for Black and Ruff. If you use github codespaces this will all be set up automatically for you. |
|
Looks good @TommyMatthews. Please see above for a couple of nitpicking comments on var names and some redundant tests to remove but I think the solution implemented here is quite elegant and neat :) |
davidhopkinson26
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter 'encode_unseen_levels' can be set to False. (default True).
If so, the levels present in the training data will be stored in during the fit method call. In transform, any new levels not present in the training data will be added to the mappings_ dictionary and thus not mapped to rare.