Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated median computer to fit successfully on all null columns #202

Merged
merged 5 commits into from
Apr 24, 2024
Merged

updated median computer to fit successfully on all null columns #202

merged 5 commits into from
Apr 24, 2024

Conversation

limlam96
Copy link
Contributor

Fixing bug where median imputer would error on all null columns

adamsardar
adamsardar previously approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@adamsardar adamsardar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small PR - straightforward bugfix and test.

I considered prompting for a test of arrow-backed DF functionality, but I think it not worthwhile given the massive overhaul coming with #185

Consider adding an entry to the changelog? Highlights a need for #165

davidhopkinson26
davidhopkinson26 requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@davidhopkinson26 davidhopkinson26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See below for a suggested minor change

tubular/imputers.py Outdated Show resolved Hide resolved
davidhopkinson26
davidhopkinson26 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@davidhopkinson26 davidhopkinson26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes

@limlam96 limlam96 merged commit 17f38fd into main Apr 24, 2024
12 checks passed
@limlam96 limlam96 deleted the bugfix/median_imputer_fit_on_all_nulls branch April 24, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhopkinson26 davidhopkinson26 davidhopkinson26 approved these changes

@adamsardar adamsardar adamsardar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@limlam96 @adamsardar @davidhopkinson26