Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.rst #270

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Update CONTRIBUTING.rst #270

merged 1 commit into from
Jul 17, 2024

Conversation

davidhopkinson26
Copy link
Contributor

Add a line to CONTRIBUTING.rst to point out the need for external contributors to create a fork.

@davidhopkinson26 davidhopkinson26 linked an issue Jul 15, 2024 that may be closed by this pull request
GitHub Codespaces requires contributor status to push #172
Closed
adamsardar
adamsardar approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@adamsardar adamsardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

What was the motivator for this? Or just something that you saw needed tweaking?

@davidhopkinson26
Copy link
Contributor Author

LGTM

What was the motivator for this? Or just something that you saw needed tweaking?

linked issue from @limlam96 #172

@davidhopkinson26 davidhopkinson26 merged commit 8ad60a0 into main Jul 17, 2024
12 checks passed
@davidhopkinson26 davidhopkinson26 deleted the davidhopkinson26-patch-1 branch July 17, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsardar adamsardar adamsardar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Codespaces requires contributor status to push
2 participants
@davidhopkinson26 @adamsardar