Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zephyr: add lv_bindings support for the Zephyr port #25

Merged

Conversation

svetelna
Copy link

This PR is related to: lvgl/lv_binding_micropython#132

This PR enables the building of files needed for lv_bindings to run on the Zephyr port of the Micropython. It requires the Zephyr driver in the lv_bindings project, which is not yet merged, but in processing in PR mentioned above.

It was tested on mimxrt1050_evk; thus, the needed display and touch driver configuration is inserted in mimxrt1050_evk.conf. This would have to be also done for other boards when they are to be used for the LVGL+Micropython+Zephyr combination.

INC += -I$(ZEPHYR_BASE)/kernel/include
INC += -I$(ZEPHYR_BASE)/arch/arm/include

#LittlevGL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance, this appears to be a mostly identical copy of the logic in py/py.mk. Is there a reason why it needs to be duplicated here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it and there is not. I will remove it. Thanks.

@embeddedt embeddedt requested a review from amirgon May 18, 2021 20:16
@amirgon amirgon merged commit 7c96f11 into lvgl:master May 20, 2021
@amirgon
Copy link
Collaborator

amirgon commented May 20, 2021

Merged! Thank you for your contribution @svetelna!

I've also merged an updated lv_binding_micropython git submodule with the new Zephyr driver included.
Please consider adding an automated test.

amirgon added a commit that referenced this pull request Jun 2, 2021
Zephyr might be incomplete, since it's not ready yet for v8.
See lvgl/lv_binding_micropython#132 and
#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants