-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rt-thread): implement rt-thread sconscript #2674
Conversation
Thank you!
Amazing! Are there any public statistics on the packages? E.g. download count? At first look only |
Hi, Here is the download statistics. https://www.youtube.com/channel/UCdDHtIfSYPq4002r27ffqPw https://www.facebook.com/RT-Thread-IoT-OS-110395723808463 https://www.linkedin.com/company/rt-thread-iot-os/ In terms of
|
Oh, I missed that, thanks.
It'd be great. We will also post it on Forum, Blog and LinkedIn.
Okay. In this case I still suggest adding only the defines you have modified and let
Is it possible to reuse lvgl's Kconfig with |
Yes, this is a problem. |
Sorry , gives me a second to change this as you said, I maybe find a better way. |
Hi, |
Hi, all set. I still keep Meanwhile, RT-Thread can also change these configurations by: All in all: Again, thanks for your suggestions! |
Hi @mysterywolf, first of all, thanks for your contribution! Could you explain a bit how the RT-Thread project structure works for external packages? Maybe it's just me, but it seems a little strange to have a downstream project's full build script/logic in our own repository. Normally I would think that these files would be in your repository and LVGL would either be a submodule or there would be logic to download a specific commit/version at build time. |
Hi, @embeddedt , the In the next PR, I will take a video to demonstrate how to use LVGL in RT-Thread projects. Because this PR has not merged, it does not work right now. That's why this PR is essential. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good, I had only a few comments.
rt-thread/lv_conf.h
Outdated
COLOR SETTINGS | ||
*====================*/ | ||
|
||
#ifdef PKG_LVGL_ENABLE_COLOR_16_SWAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it needs to be added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your reviewing. 😊
This is needed. It will let RT-Thread users to use RT-Thread Studio IDE to enable some features by using GUI method.
RT-Thread's configuration method is a little bit different from that of LVGL:
- LVGL use 1 to represent enable, 0 to represent disable.
- RT-Thread uses to define this micro to represent enable, not to define to represent disable.
Thus, it needs to do a transition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All lvgl config needs to be converted to be Rt-thread compatible?
Anyway, I merge this to let you make test and we can discuss the details in other PRs.
Thank you very much!😊 |
Description of the feature or fix
Hi,
Sorry for the late second PR, because these days I dived into the task of RT-Thread new version release.
This PR implements the Sconscript which is very essential to let RT-Thread to organize the file structure of LVGL.
Meanwhile, there is a good news: LVGL has been registered successfully in the RT-Thread software packages center and every RT-Thread user can search the LVGL official package in the RT-Thread official website. https://packages.rt-thread.org/en/detail.html?package=lvgl
I still need to several PRs to complete this RT-Thread port. Thanks ahead for your PRs reviewing.
If you want to release new version in recent days, just keep your original plan. Don't be waiting for my part.
Meco
Checkpoints