chore(libpng): fix warning #5431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```bash
lvgl/lvgl/src/libs/libpng/../../../lvgl.h:30,
from lvgl/lvgl/src/libs/libpng/lv_libpng.c:9:
lvgl/lvgl/src/libs/libpng/lv_libpng.c: In function 'decode_png_file':
lvgl/lvgl/src/libs/libpng/lv_libpng.c:270:22: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'png_uint_32' {aka 'unsigned int'} [-Wformat=]
270 | LV_LOG_ERROR("png draw buff alloc %" LV_PRIu32 " failed: %s", PNG_IMAGE_SIZE(image), filename);
| ^~~~~~~~~~~~~~~~~~~~~~~
lvgl/lvgl/src/libs/libpng/../../../src/misc/lv_log.h:124:99: note: in definition of macro 'LV_LOG_ERROR'
124 | # define LV_LOG_ERROR(...) _lv_log_add(LV_LOG_LEVEL_ERROR, LV_LOG_FILE, LV_LOG_LINE, __func__, __VA_ARGS__)
| ^~~~~~~~~~~
```
Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com>
kisvegabor
approved these changes
Jan 23, 2024
lion2tomato
pushed a commit
to lion2tomato/lvgl
that referenced
this pull request
Mar 19, 2024
VELAPLATFO-22913 Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com> Co-authored-by: pengyiqiang <pengyiqiang@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
lvgl/lvgl/src/libs/libpng/../../../lvgl.h:30, from lvgl/lvgl/src/libs/libpng/lv_libpng.c:9: lvgl/lvgl/src/libs/libpng/lv_libpng.c: In function 'decode_png_file': lvgl/lvgl/src/libs/libpng/lv_libpng.c:270:22: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'png_uint_32' {aka 'unsigned int'} [-Wformat=] 270 | LV_LOG_ERROR("png draw buff alloc %" LV_PRIu32 " failed: %s", PNG_IMAGE_SIZE(image), filename); | ^~~~~~~~~~~~~~~~~~~~~~~ lvgl/lvgl/src/libs/libpng/../../../src/misc/lv_log.h:124:99: note: in definition of macro 'LV_LOG_ERROR' 124 | # define LV_LOG_ERROR(...) _lv_log_add(LV_LOG_LEVEL_ERROR, LV_LOG_FILE, LV_LOG_LINE, __func__, __VA_ARGS__) | ^~~~~~~~~~~Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle needs to be installed) and follow the Code Conventions