Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to Github Actions #71

Merged
merged 5 commits into from
Sep 22, 2020
Merged

Migrate CI to Github Actions #71

merged 5 commits into from
Sep 22, 2020

Conversation

eploko
Copy link
Contributor

@eploko eploko commented Sep 21, 2020

This PR adopts Github Actions for the CI builds.

The old build and tests scripts from .travis.yml are migrated to .github/workflows/clojure.yml. The original .travis.yml file is deleted.

The CI job runs on every push and every pull request GH event.

Things to do before review:

  • Migrate .travis.yml
  • Prevent the code coverage step from failing
  • Replace the build status badge

The old build and tests scripts from `.travis.yml` are
migrated to `.github/workflows/clojure.yml`. The original
`.travis.yml` file is deleted.

The CI job runs on every push and every pull request GH event.
@eploko
Copy link
Contributor Author

eploko commented Sep 21, 2020

Done some preliminary work on adopting GH Actions for CI. The code coverage step fails for some reason. Will look into it tomorrow.

@eploko
Copy link
Contributor Author

eploko commented Sep 22, 2020

The code coverage step shall be fixed separately later when #72 is resolved. Appending || true to the end of the step command will do for now.

@eploko
Copy link
Contributor Author

eploko commented Sep 22, 2020

I guess this is now ready for review. Please let me know if I missed anything.

@eploko eploko marked this pull request as ready for review September 22, 2020 02:04
@lvh
Copy link
Owner

lvh commented Sep 22, 2020

Can you revert the cloverage failure being disabled so at least this PR doesn't regress (and we're sure the fix actually works)? Thanks!

@lvh lvh merged commit 9943006 into lvh:master Sep 22, 2020
@lvh
Copy link
Owner

lvh commented Sep 22, 2020

Let's give this a shot. Thanks again!

@eploko eploko deleted the gh-actions branch September 22, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants