add postParam helper method to request class #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Provides a more user friendly solution to #32 |
| var param = new Completer(); | ||
|
|
||
| List<List<int>> buffer = []; | ||
| _request.listen((data){buffer.add(data);}, onDone: (){ |
There was a problem hiding this comment.
This will add a new listener on each postParam call, the more postParam calls you make, the more performance you loose. I think we can do this once in the constructor and expand the params map with POST params, so user will be able to access them like the GET ones.
|
I have made the suggested change but this commit is not working as whilst waiting for the |
Created getParams, urlParams and postParams maps. params map now contains values as they would have been prioritised by the param() method: url then get with the addition of post params in third place. param() now allows the method to be specifed, this can be 'url', 'get' or 'post'. If no method is specified the params map will be used.
|
still fails to return POST data but collisions in the param map can now be avoided by specifying type of param you are looking for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.