Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Error in Kali #18

Closed
cmkeslin opened this issue Sep 3, 2020 · 6 comments
Closed

Compile Error in Kali #18

cmkeslin opened this issue Sep 3, 2020 · 6 comments

Comments

@cmkeslin
Copy link

cmkeslin commented Sep 3, 2020

First, thank you so much for maintaining this repository. I've been using the driver for quite some time and it's made my lenovo yoga run like a champ with Kali.

During the latest kernel upgrade I received the following gcc errors when running make

make -C /lib/modules/5.7.0-kali3-amd64/build M=/home/toor/rtw88 modules
make[1]: Entering directory '/usr/src/linux-headers-5.7.0-kali3-amd64'
CC [M] /home/toor/rtw88/main.o
gcc: error: unrecognized command-line option ‘--param=allow-store-data-races=0’; did you mean ‘--allow-store-data-races’?
make[3]: *** [/usr/src/linux-headers-5.7.0-kali3-common/scripts/Makefile.build:272: /home/toor/rtw88/main.o] Error 1
make[2]: *** [/usr/src/linux-headers-5.7.0-kali3-common/Makefile:1745: /home/toor/rtw88] Error 2
make[1]: *** [/usr/src/linux-headers-5.7.0-kali3-common/Makefile:180: sub-make] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-5.7.0-kali3-amd64'
make: *** [Makefile:80: all] Error 2

Any thoughts - I've not come accross this until this kernel. Thanks again!

@lwfinger
Copy link
Owner

lwfinger commented Sep 3, 2020

It is a Kali problem. I have no idea where those gcc command-line options come from. I had one other Kali user report that same problem.

@cmkeslin
Copy link
Author

cmkeslin commented Sep 3, 2020 via email

@mrizkimaulidan
Copy link

so are there any fixes for this issue?

@lwfinger
Copy link
Owner

lwfinger commented Sep 5, 2020

Have you asked Kali? I have used that compiler on openSUSE without ever running into that error, thus it is definitely a Kali problem!

@lwfinger lwfinger closed this as completed Sep 5, 2020
@mrizkimaulidan
Copy link

I have asked kali about this problem at here https://bugs.kali.org/view.php?id=6707, the problem is fixed now on mine. Just comment this line out at /usr/src/linux-headers-5.7.0-kali3-common/Makefile. Thank you so much for maintaining this repository sir, it helps alot!

Screenshot_2020-09-06_18-41-51

@bwhacks
Copy link

bwhacks commented Sep 8, 2020

Kali is using the Debian kernel packaging. I think the problem is that:

  • Debian kernel packaging sets a specific compiler version for building the kernel and all out-of-tree modules; currently gcc-9
  • rtw88's Makefile sets CC = gcc; and that's now gcc 10

The result of this is that Kbuild will do compiler feature probing with gcc 9 but then rtw88 is built with gcc 10, and that no longer accepts this particular option.

Setting CC also breaks cross-compiling. So please don't set it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants