Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muting during time periods as well #3

Closed
DasWookie opened this issue Oct 18, 2020 · 18 comments
Closed

Muting during time periods as well #3

DasWookie opened this issue Oct 18, 2020 · 18 comments
Assignees
Milestone

Comments

@DasWookie
Copy link

It would be terrific if the ability for the app to automatically mute during time periods. That way, say when working on a laptop late at night in bed, an unexpected audio event happens. This way, you could automatically set a time period to auto mute for "quite hours" at night so even if your device isn't locked, screensaver on, etc then audio would still be muted without you having to remember to do so until it's Ooooops, TOO late!

@lx-s
Copy link
Owner

lx-s commented Oct 27, 2020

Cool idea! And should be fairly easy to implement. I'll look into this :)

@lx-s lx-s self-assigned this Oct 27, 2020
@lx-s lx-s added this to the 1.6 milestone Oct 27, 2020
@lx-s
Copy link
Owner

lx-s commented Oct 27, 2020

Just implemented it! (10d093b...6e3f90b)

As I usually do, I let it run for a week or two, to see if there's any bugs, before making a release.

If you want to try it out yourself, you can grab it here (fresh from the compiler):

@DasWookie
Copy link
Author

Thank you. I'll have a go and will report and bugs if I run into one.

@lx-s
Copy link
Owner

lx-s commented Oct 29, 2020

Fixed some bugs, added some features:

WinMute_1.6.0-beta2_x64.zip

@blarg3891
Copy link

I keep getting "loadlibrary failed with error 125l: the specified module could not be found." Trying to run 1.6 beta2. I have tried removing 1.5 but continued to receive error. Do we need to unregister the dll or something?

@lx-s
Copy link
Owner

lx-s commented Nov 3, 2020

That's strange, since nothing should have changed in that regard between beta 1 and 2.

Could you try to install the current version of the Visual C++ Redistributable?

@blarg3891
Copy link

I installed and rebooted computer, no luck. 1.5 still works fine, 1.6 not.

@lx-s
Copy link
Owner

lx-s commented Nov 4, 2020

Thanks for trying. I've set up a virtual machine with Windows 10 20H2 and confirmed the issue.

I've attached a new version that works on the VM. Could you try again with this version:
WinMute_1.6.0-beta2_x64.zip

Still don't know what exactly caused this issue...

@blarg3891
Copy link

Works now.

@blarg3891
Copy link

Maybe i'm missing something but the hours logic may be flawed. I tried to set quite time during sleep hours (10pm - 730am) it errors saying Invalid time range (Quiet Hrs must end before they start). Its not accounting for next day. I realize this will make the logic more complicated :) but maybe its still doable.

@lx-s
Copy link
Owner

lx-s commented Nov 4, 2020

Yep - you are right. I got that logic backwards ;)
New beta: WinMute_1.6.0-beta3_x64.zip

Hopefully it's the last beta :)

@blarg3891
Copy link

Not sure this was missed when you changed logic. Quiet time mutes at the right time but does not unmute. I tried with the "force unmute" checked or unchecked. Still doesnt unmute automatically.

Thanks :)

@lx-s
Copy link
Owner

lx-s commented Nov 12, 2020

Hm. Do you restart your PC in-between?
(I've tested it with my work PC (which runs 24/7) and It works as expected.)

@blarg3891
Copy link

blarg3891 commented Nov 12, 2020 via email

@lx-s
Copy link
Owner

lx-s commented Nov 27, 2020

I think this feature is stable now (in my current development version).
I'll have to fix the timing problems mentioned in #4 and then I'll release 1.6 sometime next week.

Thanks for your patience.

@blarg3891
Copy link

Cool, thanks so much!.

@lx-s
Copy link
Owner

lx-s commented Dec 4, 2020

Because of #4 I'll postpone the release a bit more. If you want to use quiet hours now, you can use the beta attached in #4 though :)

@lx-s
Copy link
Owner

lx-s commented Dec 18, 2020

Added in version 1.6.0

@lx-s lx-s closed this as completed Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants