Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Installer script #28

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Update Installer script #28

merged 3 commits into from
Oct 8, 2023

Conversation

bovirus
Copy link
Contributor

@bovirus bovirus commented Oct 6, 2023

@lx-s

Update installer script
Move all strings/custom emssages ina separate file for better managemnT
Setup uninstall icon
Setup app version get from exe
Use GNU 3.0 RTF license file
Many other improvements.

Note: I already included trings for italian language but I commented them to maintain current situation until will be available italian language for GUI.

Update instalelr script
Move all strings/custom emssages ina separate file for better managemnT
Setup uninstall icon
Setup app version get from exe
Use GNU 3.0 RTF license file
Many other improvements.
@lx-s
Copy link
Owner

lx-s commented Oct 6, 2023

Hey there - thanks for your work!

I’ll look at it in detail, when I am at my PC.

the only thing that comes to mind: I don’t want to change the license from BSD 3-clause to GPLv3. I am quite okay with the very permissive license that WinMute currently has :)

@bovirus
Copy link
Contributor Author

bovirus commented Oct 6, 2023

@lx-s

Sorry for my error about license type.
Is it availbale a BSD.3 license text in rtf format?
Or could be possible to change the text layout without 80 chars max line lenght, like

WinMute

       Copyright (C) 2023 Alexander Steinhoefer

Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

  • Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

  • Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

  • Neither the name of the author nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE

@lx-s lx-s changed the base branch from main to dev October 7, 2023 05:30
@lx-s
Copy link
Owner

lx-s commented Oct 7, 2023

No problem :)
Here you go!
license.zip

@bovirus
Copy link
Contributor Author

bovirus commented Oct 8, 2023

@lx-s

Coudl you check and approve Inno Setup changes here

#28

Thanks.

@lx-s lx-s merged commit 9b50012 into lx-s:dev Oct 8, 2023
@bovirus
Copy link
Contributor Author

bovirus commented Oct 8, 2023

@lx-s

When you camn pelase rebuild teh instalelr and publish it for final check.
Thanks.
Please close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants