Allow adding external interfaces to an OVN network

[SpiffyEight77]

Description

• Allow adding external interfaces to an OVN network
• close Allow adding external interfaces to an OVN network #937

Details

• OS: Ubuntu 24.04
• Arch: x86_64

Test result

create OVN network with bridge.external_interfaces

# incus network create ext-ifac-ovn bridge.external_interfaces=ens18.10/ens18/10 --type=ovn network=test-network --debug
Network ext-ifac-ovn created

# incus network ls
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
|     NAME     |   TYPE   | MANAGED |      IPV4       |           IPV6            | DESCRIPTION | USED BY |  STATE  |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
| br-int       | bridge   | NO      |                 |                           |             | 0       |         |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
| ens18        | physical | NO      |                 |                           |             | 0       |         |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
| ens18.10     | vlan     | NO      |                 |                           |             | 0       |         |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
| ext-ifac-ovn | ovn      | YES     | 10.6.133.1/24   | fd42:3332:1564:37bd::1/64 |             | 0       | CREATED |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
| incusbr0     | bridge   | YES     | 10.46.82.1/24   | fd42:a560:1040:84ee::1/64 |             | 2       | CREATED |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
| incusovn2    | bridge   | NO      |                 |                           |             | 0       |         |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
| incusovn2a   | unknown  | NO      |                 |                           |             | 0       |         |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
| incusovn2b   | unknown  | NO      |                 |                           |             | 0       |         |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
| isolated-ovn | ovn      | YES     | 10.168.199.1/24 | fd42:5d7e:c084:dcb0::1/64 |             | 0       | CREATED |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
| lo           | loopback | NO      |                 |                           |             | 0       |         |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
| lxcbr0       | bridge   | NO      |                 |                           |             | 0       |         |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
| ovn-network  | ovn      | YES     | 10.71.151.1/24  | fd42:69ae:dc4b:fb01::1/64 |             | 0       | CREATED |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
| ovs-system   | unknown  | NO      |                 |                           |             | 0       |         |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+
| test-network | bridge   | YES     | 10.97.209.1/24  | fd42:f32:39dc:32b::1/64   |             | 2       | CREATED |
+--------------+----------+---------+-----------------+---------------------------+-------------+---------+---------+

# incus network info ext-ifac-ovn
Name: ext-ifac-ovn
MAC address: 00:16:3e:33:66:9b
MTU: 1500
State: up
Type: broadcast

IP addresses:
  inet  10.6.133.1/24 (link)
  inet6 fd42:3332:1564:37bd::1/64 (link)

Network usage:
  Bytes received: 0B
  Bytes sent: 0B
  Packets received: 0
  Packets sent: 0

OVN:
  Chassis: playground
  Logical router: incus-net39-lr


# ovn-nbctl lsp-get-addresses ens18.10-lsp-router
unknown

delete OVN network with bridge.external_interfaces

# incus network delete ext-ifac-ovn
Network ext-ifac-ovn deleted

# ovn-nbctl lsp-get-addresses ens18.10-lsp-router
ovn-nbctl: ens18.10-lsp-router: port name not found

[stgraber]

Looks good. I'll just keep it open a tiny bit longer as I want to do:

• Add API extension for this
• Test behavior in a cluster where we would want this key to be per-server rather than global
• Try to de-duplicate the parsing logic between the bridge and ovn drivers