create_detached_idmapped_mount: avoid double close #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd_userns is defined as __do_close, so if it is not -EBADF, it will be closed on exit. So we need to either set it to -EBADF after closing it, or just not manually close it. My mistake in reviewing the previous patch. Signed-off-by: Serge Hallyn <serge@hallyn.com>
hallyn
force-pushed
the
2024-05-25/avoiddoubleclose
branch
from
f533fbc
to
1b7da94
Compare
brauner
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fd_userns is defiend ad __do_close, so if it is not -EBADF, it will be closed on exit. So we need to either set it to -EBADF after closing it, or just not manually close it.
My mistake in reviewing the previous patch.