-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree-wide: only rely on sys/ headers to avoid conflicts with linux/ headers #4181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is incompatible with sys/mount.h and causes massive headaches. Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>
brauner
force-pushed
the
2022-08-10.fixes
branch
from
August 10, 2022 10:15
49e7a3e
to
54d4aec
Compare
Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>
brauner
force-pushed
the
2022-08-10.fixes
branch
from
August 10, 2022 10:16
54d4aec
to
63468ab
Compare
Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>
brauner
changed the title
tree-wide: only rely on sys/mount.h
tree-wide: only rely on sys/ headers to avoid conflicts with linux/ headers
Aug 10, 2022
Testsuite passed |
@graysky2 can you test, please? |
Testsuite passed |
@stgraber this can be merged in any case. We should remove any direct or indirect include of |
I'm using lxc 5.0.1 and met some build issue with glibc2.36. I want to know that will these commits be merge to stable-5.0 branch. |
hauke
added a commit
to hauke/packages
that referenced
this pull request
Dec 17, 2022
Backport patches from upstream lxc master to fix compilation against glibc 2.36. The changes were added in these pull requests: lxc/lxc#4179 lxc/lxc#4181 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
hauke
added a commit
to hauke/packages
that referenced
this pull request
Dec 17, 2022
Backport patches from upstream lxc master to fix compilation against glibc 2.36. The changes were added in these pull requests: lxc/lxc#4179 lxc/lxc#4181 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
hauke
added a commit
to hauke/packages
that referenced
this pull request
Dec 18, 2022
Backport patches from upstream lxc master to fix compilation against glibc 2.36. The changes were added in these pull requests: lxc/lxc#4179 lxc/lxc#4181 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
hauke
added a commit
to hauke/packages
that referenced
this pull request
Dec 21, 2022
Backport patches from upstream lxc master to fix compilation against glibc 2.36. The changes were added in these pull requests: lxc/lxc#4179 lxc/lxc#4181 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
neheb
pushed a commit
to openwrt/packages
that referenced
this pull request
Dec 23, 2022
Backport patches from upstream lxc master to fix compilation against glibc 2.36. The changes were added in these pull requests: lxc/lxc#4179 lxc/lxc#4181 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
alexeys85
pushed a commit
to alexeys85/packages
that referenced
this pull request
Jan 11, 2023
Backport patches from upstream lxc master to fix compilation against glibc 2.36. The changes were added in these pull requests: lxc/lxc#4179 lxc/lxc#4181 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Brauner (Microsoft) christian.brauner@ubuntu.com