Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-wide: only rely on sys/ headers to avoid conflicts with linux/ headers #4181

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

brauner
Copy link
Member

@brauner brauner commented Aug 10, 2022

Signed-off-by: Christian Brauner (Microsoft) christian.brauner@ubuntu.com

It is incompatible with sys/mount.h and causes massive headaches.

Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>
Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>
Signed-off-by: Christian Brauner (Microsoft) <christian.brauner@ubuntu.com>
@brauner brauner changed the title tree-wide: only rely on sys/mount.h tree-wide: only rely on sys/ headers to avoid conflicts with linux/ headers Aug 10, 2022
@lxc-jenkins
Copy link

Testsuite passed

@brauner
Copy link
Member Author

brauner commented Aug 10, 2022

@graysky2 can you test, please?

@lxc-jenkins
Copy link

Testsuite passed

@brauner brauner requested a review from stgraber August 10, 2022 13:08
@brauner
Copy link
Member Author

brauner commented Aug 10, 2022

@stgraber this can be merged in any case. We should remove any direct or indirect include of linux/mount.h anyway.

@stgraber stgraber merged commit b3defe0 into lxc:master Aug 10, 2022
@graysky2
Copy link
Contributor

@stgraber @brauner - confirmed, built fine, thank you for the rapid fix!

@leimaohui
Copy link

I'm using lxc 5.0.1 and met some build issue with glibc2.36. I want to know that will these commits be merge to stable-5.0 branch.

hauke added a commit to hauke/packages that referenced this pull request Dec 17, 2022
Backport patches from upstream lxc master to fix compilation against
glibc 2.36.

The changes were added in these pull requests:
lxc/lxc#4179
lxc/lxc#4181

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
hauke added a commit to hauke/packages that referenced this pull request Dec 17, 2022
Backport patches from upstream lxc master to fix compilation against
glibc 2.36.

The changes were added in these pull requests:
lxc/lxc#4179
lxc/lxc#4181

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
hauke added a commit to hauke/packages that referenced this pull request Dec 18, 2022
Backport patches from upstream lxc master to fix compilation against
glibc 2.36.

The changes were added in these pull requests:
lxc/lxc#4179
lxc/lxc#4181

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
hauke added a commit to hauke/packages that referenced this pull request Dec 21, 2022
Backport patches from upstream lxc master to fix compilation against
glibc 2.36.

The changes were added in these pull requests:
lxc/lxc#4179
lxc/lxc#4181

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
neheb pushed a commit to openwrt/packages that referenced this pull request Dec 23, 2022
Backport patches from upstream lxc master to fix compilation against
glibc 2.36.

The changes were added in these pull requests:
lxc/lxc#4179
lxc/lxc#4181

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
alexeys85 pushed a commit to alexeys85/packages that referenced this pull request Jan 11, 2023
Backport patches from upstream lxc master to fix compilation against
glibc 2.36.

The changes were added in these pull requests:
lxc/lxc#4179
lxc/lxc#4181

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants