Fix _ErrorLog not iterable
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following mypy error:
```
lib/galaxy/tool_util/linters/xsd.py:28: error: "_ErrorLog" has no attribute
"__iter__" (not iterable) [attr-defined]
for error in xsd.error_log:
^~~~~~~~~~~~~
```
xref: https://github.com/galaxyproject/galaxy/pull/17081/files#r1490662640
scoder
reviewed
Feb 19, 2024
lxml-stubs/etree.pyi
Outdated
Comment on lines
583
to
584
| class _ErrorLog: | ||
| def __iter__(self) -> Iterator["_LogEntry"]: ... |
There was a problem hiding this comment.
It's actually not _ErrorLog that's iterable but its base class. Also, again, there are lots of public attributes and methods missing here. It's best to add all of them.
There was a problem hiding this comment.
Thanks, I think I've added all the public attributes/properties/methods listed at https://lxml.de/apidoc/lxml.etree.html for _LogEntry, _ErrorLog and its parent classes. Let me know if I've missed some.
…gEntry`` and ``_ErrorLog``
nsoranzo
force-pushed
the
_ErrorLog_iterable
branch
from
0874496
to
b680bc0
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following mypy error:
xref: https://github.com/galaxyproject/galaxy/pull/17081/files#r1490662640