Fix <script> and <style> text content serialization #218

plq · 2016-12-21T14:31:02Z

Behold:

>>> from six import BytesIO
>>> from lxml import etree
>>> f = BytesIO()
>>> with etree.htmlfile(f) as xf:
...     elt = etree.Element('script')
...     elt.text = "if (a < b);"
...     xf.write(elt)
...
>>> f.getvalue()
'<script>if (a < b);</script>'

... which is correct.

However:

>>> f = BytesIO()
>>> with etree.htmlfile(f) as xf:
...     with xf.element('script'):
...         xf.write("if (a < b);")
...
>>> f.getvalue()
'<script>if (a &lt; b);</script>'

... which is not only incorrect, but also quite annoying :)

This patch is an attempt at fixing it.

scoder · 2016-12-22T20:47:32Z

src/lxml/serializer.pxi

@@ -954,7 +954,15 @@ cdef class _IncrementalFileWriter:
                    if self._status > WRITER_IN_ELEMENT or content.strip():
                        raise LxmlSyntaxError("not in an element")
                content = _utf8(content)
-                tree.xmlOutputBufferWriteEscape(self._c_out, _xcstr(content), NULL)
+                if c_method == OUTPUT_METHOD_XML:


This seems reversed. Shouldn't your special casing apply only to HTML, instead of everything but XML?

plq force-pushed the master branch from 1633f86 to b383b32 Compare December 21, 2016 14:33

scoder reviewed Dec 22, 2016

View reviewed changes

fix <script> text content serialization in incremental html mode

ea1a743

plq force-pushed the master branch from b383b32 to ea1a743 Compare December 23, 2016 06:26

scoder merged commit bc77035 into lxml:master Dec 23, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix <script> and <style> text content serialization #218

Fix <script> and <style> text content serialization #218

plq commented Dec 21, 2016 •

edited

Loading

scoder Dec 22, 2016

plq Dec 23, 2016

Fix <script> and <style> text content serialization #218

Fix <script> and <style> text content serialization #218

Conversation

plq commented Dec 21, 2016 • edited Loading

scoder Dec 22, 2016

Choose a reason for hiding this comment

plq Dec 23, 2016

Choose a reason for hiding this comment

plq commented Dec 21, 2016 •

edited

Loading