Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set open graph meta tags without requiring series taxonomy #327

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Set open graph meta tags without requiring series taxonomy #327

merged 1 commit into from
Mar 13, 2022

Conversation

alexanderdavide
Copy link
Collaborator

Description

Currently, Open Graph is only set when the series taxonomy is used. This is an inopportune default which this PR addresses.

Citing @Xen-Echo from #166:

Testing locally the open graph template only fails to render if you have pages with "series" front matter and haven't also specified the corresponding "series" taxonomy. I personally don't think this should stop the open graph template rendering though as you lose the basic open graph fields like image etc. when you copy a page link somewhere that supports rich URLs.

Whoever sets series in front mattter configs without having the series taxonomy enabled in the site configuration should not be 'protected'.

Issue Number:

#166

Checklist

Yes, I included all necessary artefacts, including:

  • Tests
  • Documentation
  • Implementation (Code and Ressources)
  • Example

Testing Checklist

Yes, I ensured that all of the following scenarios were tested:

  • Desktop Light Mode (Default)
  • Desktop Dark Mode
  • Desktop Light RTL Mode
  • Desktop Dark RTL Mode
  • Mobile Light Mode
  • Mobile Dark Mode
  • Mobile Light RTL Mode
  • Mobile Dark RTL Mode

Notify the following users

@netlify
Copy link

netlify bot commented Mar 13, 2022 •
edited
Loading

✔️ Deploy Preview for anatole-demo ready!

🔨 Explore the source changes: 579d768

🔍 Inspect the deploy log: https://app.netlify.com/sites/anatole-demo/deploys/622e15d0a8952b0009eec06a

😎 Browse the preview: https://deploy-preview-327--anatole-demo.netlify.app

@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

lxndrblz
lxndrblz approved these changes Mar 13, 2022
View reviewed changes
Copy link
Owner

@lxndrblz lxndrblz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderdavide LGTM. Thanks for taking care of this.

@lxndrblz lxndrblz merged commit 069b324 into lxndrblz:master Mar 13, 2022
@lxndrblz lxndrblz added the enhancement New feature or request label Mar 19, 2022
@lxndrblz lxndrblz mentioned this pull request May 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxndrblz lxndrblz lxndrblz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
🛣 Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderdavide @lxndrblz