Fixed crash with DND into side-pane under Wayland #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch is safer with X11 too because it gets the required info before showing the DND menu. Fixes #838 NOTE: The misplacement of the DND menu can't be fixed in this case because the relevant classes don't include the required info. Unless Qt finds solutions/workarounds for Wayland nonsenses, Wayland users should tolerate them.
tsujan
force-pushed
the
wayland_sidepane_dnd
branch
from
e8d4d48
to
3088f1f
Compare
|
Straightforward. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch is safer with X11 too because it gets the required info before showing the DND menu.
Fixes #838
NOTE: The misplacement of the DND menu can't be fixed in this case because the relevant classes don't include the required info. Unless Qt finds solutions/workarounds for Wayland nonsenses, Wayland users should tolerate them.