-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LXQt panel: grouped window popup disappears on mouseover with patched versions of Qt5 (in Arch) #1600
Comments
What your described under "Current Behavior" isn't reproducible. If you think you could describe the problem in a better way, explain it in a step by step way under "Steps to Reproduce" (1..., 2.....) |
If so, you already know that the problem isn't in LXQt; why opening an issue here? |
@tsujan: |
Steps to Reproduce (for bugs)
|
@DanielPrjct As for reporting an issue, please include the relevant info and avoid long comments. As far as I was able to extract it from your comments, what you told was as simple as this: After upgrading Qt to the versions "5.15.2+kde..." provided by Arch, the popup of grouped windows in Panel's task manager disappears as soon as you move the mouse cursor over it. This can be a distro issue, a problem in Arch packages "5.15.2+kde...", or a new bug in Qt. In the last case, a backward compatible workaround might be needed. Thanks for the report! |
Reproducible here, at 5. no way to select any window in the group because list disappears.
|
@stefonarch |
this is not "a patched version of Qt5". As mentioned above, this is caused by an actual upstream Qt commit, https://code.qt.io/cgit/qt/qtbase.git/commit/?h=5.15&id=62f86b9b7ab3421c7a74c4c05a186847c76bfb28 |
It's patched by using upstream patches (and "...+kde+r..." shows that). The official releases are here: https://download.qt.io/official_releases/qt/5.15/ |
@stefonarch diff -ruNp lxqt-panel-orig/plugin-taskbar/lxqttaskgroup.cpp lxqt-panel/plugin-taskbar/lxqttaskgroup.cpp
--- lxqt-panel-orig/plugin-taskbar/lxqttaskgroup.cpp
+++ lxqt-panel/plugin-taskbar/lxqttaskgroup.cpp
@@ -576,7 +576,8 @@ void LXQtTaskGroup::dragLeaveEvent(QDrag
void LXQtTaskGroup::mouseMoveEvent(QMouseEvent* event)
{
// if dragging the taskgroup, do not show the popup
- setPopupVisible(false, true);
+ if (event->buttons() & Qt::LeftButton)
+ setPopupVisible(false, true);
LXQtTaskButton::mouseMoveEvent(event);
}
|
Tha patch fixes the problem for me. |
@antonio-rojas
|
Yes to both. |
Good :) I'll make a PR today. |
The lack of checking didn't have an effect with the official Qt releases but it causes a bug with the latest official patches. Logically, the pressed mouse buttons should have always been checked. Closes #1600
Tested the PR, looks fine. |
The lack of checking didn't have an effect with the official Qt releases but it causes a bug with the latest official patches. Logically, the pressed mouse buttons should have always been checked. Closes #1600
Description:
Arch Linux (up-to-date) with LXQt.
I've updated my system at 2021/04/08 and 2021/04/09 and since qt5-... packages versions are qt5-....version+kde+version, LXQt panel doesn't allow to select and maximize/resize any grouped minimized window.
As example: two or more Qterminal instances in the same desktop, or Thunderbird main window and its Write window in other desktop.
Grouped windows are showed (pop up menu appears with left click) by LXQt Panel, but when I try to select one minimized window, the pop up menu dissapear.
Once all windows in the same desktop are minimized and showed in LXQt Panel, neither of them can be maximized nor resized from LXQt taskbar (Task Manager).
The only updated packages that I can see perhaps related to this bug are:
qt5-base 5.15.2+kde+r171-2
qt5-declarative 5.15.2+kde+r24-1
qt5-svg 5.15.2+kde+r5-1
qt5-wayland 5.15.2+kde+r11-1 ? (I'm not using Wayland at all).
All are now "mainversion+kde+version"...
Downgrading to previous "non-kde" versions seems solve the issue...
Additional info:
liblxqt 0.16.0-1
lximage-qt 0.16.0-1 (lxqt)
lxqt-about 0.16.0-1 (lxqt)
lxqt-admin 0.16.0-1 (lxqt)
lxqt-archiver 0.3.0-1 (lxqt)
lxqt-config 0.16.1-1 (lxqt)
lxqt-globalkeys 0.16.0-1 (lxqt)
lxqt-notificationd 0.16.0-1 (lxqt)
lxqt-openssh-askpass 0.16.0-1 (lxqt)
lxqt-panel 0.16.1-1 (lxqt)
lxqt-policykit 0.16.0-1 (lxqt)
lxqt-powermanagement 0.16.0-1 (lxqt)
lxqt-qtplugin 0.16.0-1 (lxqt)
lxqt-runner 0.16.0-1 (lxqt)
lxqt-session 0.16.0-1 (lxqt)
lxqt-sudo 0.16.0-1 (lxqt)
lxqt-themes 0.16.0-1 (lxqt)
obconf-qt 0.16.0-1 (lxqt)
openbox 3.6.1-7 (lxde lxde-gtk3 lxqt)
pcmanfm-qt 0.16.0-1 (lxqt)
qterminal 0.16.1-1 (lxqt)
qt5-base (5.15.2-5 -> 5.15.2+kde+r171-1)
qt5-svg (5.15.2-2 -> 5.15.2+kde+r5-1)
qt5-declarative (5.15.2-1 -> 5.15.2+kde+r24-1)
qt5-wayland (5.15.2-1 -> 5.15.2+kde+r11-1)
Expected Behavior
Open two or more instances of an application in different windows at the same desktop, or open a dialog window of an application, and then minimize one or more windows. They will be grouped at task manager. Left click in each group must show its minimized windows and allow select what window must be maximized or resized.
Current Behavior
Left click in a group in Task Manager pop up a lit of minimized windows, but they dissapear immediatly, or when user try to select one of them hovering the cursor.
Possible Solution
@arojas, KDE and qt5 maintainer at Arch Linux team, says that this issue is caused by this Qt change;
[url]
https://code.qt.io/cgit/qt/qtbase.git/commit/?h=5.15&id=62f86b9b7ab3421c7a74c4c05a186847c76bfb28
[/url]
Steps to Reproduce (for bugs)
Context
System Information
The text was updated successfully, but these errors were encountered: