-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port lxqt-panel to KWindowSystem #81
Conversation
I'm in favour of adopting the same approach as KDE, although to ease the transition it would possibly be a good idea to develop two separate lxqt-panel plugins: One "legacy" systemtray with xembed support and one new-style tray. Users who care will be able to use the legacy tray, and some time in the future we will drop it from the codebase and make it installable as a third party plugin. This seems like it would please everyone, at the expense of UX for legacy applications. |
KDE's reasons to their new approach for the system tray aim better UX with uniform icons, menu etc. IMHO, if we want to keep classic and support all applications, we should mantain a system tray for X and another one for Wayland when time comes. |
About the keyboard indicator, I'm wondering if wayland supports xkbcommon. I've read something about that, but it needs to be confirmed. If so, I could port this plugin to xkbcommon. |
Yes, we could use it. Does not look easy, though. |
e667a03
to
0b8516b
Compare
Rebased. |
Whats the status on it? Is there any work left to do on it? |
It's working and must be tested. The only components that need X11 is the keyboard indicator and the system tray, but they are working just like before. |
The urgency hint on taskbar is not working properly. I'm waiting for the KWindowSystem fix. |
@paulolieuthier code lgtm. merge it as soon as you're comfortable with it. it'll only be tested once its in master tbh. |
I'd like to merge it. The urgency hint is only a problem with KDevelop, apparently. The real problem is that it's using 21% of my CPU and memory usage increased 70%. I've got to profile it before merging. |
Merge it then. |
Keyboard indicator and System tray still need Xlib/xcb, and the urgency hint behavior is not working, as KWindowSystem does not support it properly yet.
I'm dropping Qt4 support here, as discussed in the ML. This is not targeted at 0.8 release anyway.
We shall decide how we are going to approach the system tray issue, as KWindowSystem will not support it (as seen here and here).