-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ported to Qt6 and used layer-shell-qt #277
Conversation
Porting to Qt6 and using layer-shell-qt are dome simultaneously to make lxqt-runner completely ready for Wayland.
Working fine - removing the last window rules from my wayland configurations now. |
If you find the time, please also test it under X11 (I will later). After all, 99% percent of LXQt users have X11 sessions ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea how to remove that "changes requested though. Ok, found it. |
Yes, I'd seen it. It worried me, to be honest ;) You know that I love labwc (I'm using it right now), but changing something in our code just to make it work under its git source doesn't seem OK to me. |
If you want to remove it without approving, you could press the "Re-request review" icon beside your avatar on a PR page. |
Quick test only, but seems good so far on X11 here (with lxqt/lxqt-globalkeys#278). Thank you! |
That is a very good stance from my point of view as well. |
Porting to Qt6 and using layer-shell-qt are dome simultaneously to make lxqt-runner completely ready for Wayland.