Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported to Qt6 and used layer-shell-qt #277

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Ported to Qt6 and used layer-shell-qt #277

merged 1 commit into from
Mar 25, 2024

Conversation

tsujan
Copy link
Member

@tsujan tsujan commented Mar 10, 2024

Porting to Qt6 and using layer-shell-qt are dome simultaneously to make lxqt-runner completely ready for Wayland.

Porting to Qt6 and using layer-shell-qt are dome simultaneously to make lxqt-runner completely ready for Wayland.
@tsujan tsujan marked this pull request as draft March 10, 2024 16:25
@stefonarch
Copy link
Member

Working fine - removing the last window rules from my wayland configurations now.

@tsujan
Copy link
Member Author

tsujan commented Mar 10, 2024

If you find the time, please also test it under X11 (I will later). After all, 99% percent of LXQt users have X11 sessions ;)

Copy link
Member

@stefonarch stefonarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dialog.cpp Show resolved Hide resolved
@stefonarch
Copy link
Member

stefonarch commented Mar 24, 2024

No idea how to remove that "changes requested though.

Ok, found it.

@tsujan
Copy link
Member Author

tsujan commented Mar 24, 2024

See labwc/labwc#1653 (comment)

Yes, I'd seen it. It worried me, to be honest ;) You know that I love labwc (I'm using it right now), but changing something in our code just to make it work under its git source doesn't seem OK to me.

@tsujan
Copy link
Member Author

tsujan commented Mar 24, 2024

No idea how to remove that "changes requested though.

If you want to remove it without approving, you could press the "Re-request review" icon beside your avatar on a PR page.

@Chiitoo
Copy link

Chiitoo commented Mar 24, 2024

Quick test only, but seems good so far on X11 here (with lxqt/lxqt-globalkeys#278).

Thank you!

@Consolatis
Copy link

Consolatis commented Mar 24, 2024

See labwc/labwc#1653 (comment)

Yes, I'd seen it. It worried me, to be honest [..] changing something in our code just to make it work under its git source doesn't seem OK to me.

That is a very good stance from my point of view as well.
We should try to ensure that all sides respect the protocol as close as possible and not write applications that work for compositor x and y but require changes for z and instead rather implement based on the protocol and raise issues where a compositor (or application) has the wrong assumptions or behavior.

@tsujan tsujan marked this pull request as ready for review March 25, 2024 15:44
@tsujan tsujan merged commit a6509db into master Mar 25, 2024
@tsujan tsujan deleted the qt6_shell branch March 25, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants