lxqt-sudo: allow bidirectional communication with launched process #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that lxqt-sudo should not regress in terms of functionality compared to its CLI counterparts, and given that the code looks fairly sane, +1. Friendly reminder that I'm a fan of +2s prior to merging. |
tsimonq2
approved these changes
Jan 3, 2024
It definitely needs @palinek's approval. |
Also for better readability: - add comments - use one constant instead of plain number here-and-there
..and optimize splitting of output (for large outputs it may have been a penalty to split the whole batch into lines).
Pr 210 enhancements
palinek
added a commit
that referenced
this pull request
Jan 12, 2024
lxqt-sudo: allow bidirectional communication with launched process
|
Landed in e4a321e Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209. I tested the changes pretty well, but definitely someone who knows more about pseudoterminals should look closely at this since this is unfamiliar territory for me.