Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colors of TableBody::paintCell are a joke #170

Closed
tsujan opened this issue Sep 18, 2019 · 0 comments · Fixed by #174
Closed

Colors of TableBody::paintCell are a joke #170

tsujan opened this issue Sep 18, 2019 · 0 comments · Fixed by #174
Assignees
@tsujan

Comments

@tsujan
Copy link
Member

tsujan commented Sep 18, 2019

At the time Qps was created, they might seem serious. I found the problem only with a special Kvantum theme -- Kvantum is good at revealing incorrect style codes.

Will correct it soon.
@tsujan tsujan self-assigned this Sep 18, 2019
This was referenced Sep 19, 2019
Closed
Closed
tsujan added a commit that referenced this issue Sep 24, 2019
@tsujan
Big patch: Fixed painting of cells, branch lines and...
3a4c4b1 
Among the fixed issues:

 (1) The tree branch lines are fixed. Previously, they were drawn incorrectly, their texts were positioned badly, and the "windows" style was used for drawing their expanders — something no sensible code should do.

 (2) Cell heights are fixed. Previously, they cut texts with big fonts. Now, they are calculated by the active widget style.

 (3) Background and foreground colors are corrected (the background fix may not be very visible with Fusion or Breeze).

 (4) A cause of crash is removed (previously: start Qps → press `Shift` → click inside the view → crash).

 (5) Activated `Ctrl+A` for selecting all rows, `Alt+H` for hanging up and `Alt+K` for killing processes. They existed before but didn't work.

Closes #170 and closes #171 and closes #172
@tsujan tsujan mentioned this issue Sep 24, 2019
Merged
agaida pushed a commit that referenced this issue Sep 27, 2019
@tsujan @agaida
Big patch: Fixed painting of cells, branch lines and...
82e7fa8 
Among the fixed issues:

 (1) The tree branch lines are fixed. Previously, they were drawn incorrectly, their texts were positioned badly, and the "windows" style was used for drawing their expanders — something no sensible code should do.

 (2) Cell heights are fixed. Previously, they cut texts with big fonts. Now, they are calculated by the active widget style.

 (3) Background and foreground colors are corrected (the background fix may not be very visible with Fusion or Breeze).

 (4) A cause of crash is removed (previously: start Qps → press `Shift` → click inside the view → crash).

 (5) Activated `Ctrl+A` for selecting all rows, `Alt+H` for hanging up and `Alt+K` for killing processes. They existed before but didn't work.

Closes #170 and closes #171 and closes #172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsujan tsujan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Big patch: Fixed painting of cells, branch lines and... lxqt/qps
1 participant
@tsujan