Removed the cause of a huge memory leak #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes a huge memory leak in `Proc::refresh()`. NOTE: It may seem that there is still a relatively smaller memory leak in setting the graph as the tray and window icon. However, the increase in memory usage stops after a while. So, this closes #101
Merged
|
Looks good. Why do not you merge it now? |
Each PR needs the approval of another dev -- in this case, you gave it by saying "looks good". It definitely removes a big memory leak. If there's still a leak, it should be small but Qt's Please continue finding and fixing issues in qps's code! Functions with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes a huge memory leak in
Proc::refresh().NOTE: It may seem that there is still a relatively smaller memory leak in setting the graph as the tray and window icon. However, the increase in memory usage stops after a while. So, this closes #101