Made column DND predictable — and much more #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #166 Also: (1) In most process monitors, the downward sort indicator has different meanings for different fields. For example, it means sorting from high to low for CPU and memory, while it shows the alphabetical order for strings (a → z). Qps seems to follow the same rule. Therefore, the default indicator is changed from "SortUp" to "SortDown". (2) A small mistake is fixed in adding columns. Previously, the PID field would be loaded as the first column with the next startup even if it was moved by DND and there was no tree). (3) A bug is fixed in column removal. Previously, if the removed column was positioned before the sorted one, sorting would become incorrect until the next session. NOTE: I think most GUI problems are fixed now.
|
Please merge this (after testing, of course)! I have 2 heavy patches and, whenever I find time, I make more (because there are many issues to fix), so that I might lose track of their order if they're piled up. Later, I might not be able to work on Qps so actively, because of other LXQt projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166
Also:
(1) In most process monitors, the downward sort indicator has different meanings for different fields. For example, it means sorting from high to low for CPU and memory, while it shows the alphabetical order for strings (a → z). Qps seems to follow the same rule. Therefore, the default indicator is changed from "SortUp" to "SortDown".
(2) A small mistake is fixed in adding columns. Previously, the PID field would be loaded as the first column with the next startup even if it was moved by DND and there was no tree).
(3) A bug is fixed in column removal. Previously, if the removed column was positioned before the sorted one, sorting would become incorrect until the next session.
NOTE: I think most GUI problems are fixed now.