Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid including source files names into the library binary #71

Merged
merged 2 commits into from
May 25, 2016
Merged

Avoid including source files names into the library binary #71

merged 2 commits into from
May 25, 2016

Conversation

f2404
Copy link
Contributor

@f2404 f2404 commented May 15, 2016 •
edited
Loading

This partly resolves #70

@f2404
Copy link
Contributor Author

f2404 commented May 15, 2016 •
edited
Loading

The first commit replaces assert() calls with Q_ASSERT() as the latter does not cause files paths to be included into the binary.
The second commit comments out a couple of debug messages that call __FILE__ macro (which also made paths be included).

@f2404 f2404 changed the title Replace assert() with Q_ASSERT() Avoid including source files names into the library binary May 15, 2016
@pmattern
Copy link
Contributor

pmattern commented May 17, 2016 •
edited
Loading

The "partly" in the first comment doesn't apply any longer, does it? Just saying to avoid this PR doesn't get merged because of it.

@f2404
Copy link
Contributor Author

f2404 commented May 17, 2016 •
edited
Loading

Yes, the issue is fully resolved by this patch.
I've updated the comments.

@pvanek pvanek merged commit 5ebc2c0 into lxqt:master May 25, 2016
@f2404 f2404 deleted the 70_assert branch May 25, 2016 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Path of build directory gets incorporated in shared library
3 participants
@f2404 @pmattern @pvanek