Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18 Proposal exit position should point to correct location #19

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Conversation

xcariba
Copy link
Collaborator

@xcariba xcariba commented Aug 6, 2020

It should point to $0 if present

@xcariba xcariba requested a review from pisv August 6, 2020 16:29
@pisv pisv linked an issue Aug 7, 2020 that may be closed by this pull request
@pisv
Copy link
Collaborator

pisv commented Aug 7, 2020

The patch looks good, but after some experimenting with different approaches/different snippets, it seems that an alternative fix that I have committed to the pull request branch works more consistently with regard to "tabbing" between tab stops and with regard to the "default" behavior (when there is no $0 in the snippet). For example, for the following snippet

if (${1:true|false}) {
   $2
}$0

it produces exactly the same behavior ("tabbing" and all that) as for

if (${1:true|false}) {
   $2
}

Could you try it for yourself and see if that works for you?

@xcariba
Copy link
Collaborator Author

xcariba commented Aug 13, 2020

Works for me!

Copy link
Collaborator

@pisv pisv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for your contribution and feedback.

@pisv pisv merged commit 8e876b5 into master Aug 13, 2020
@pisv pisv deleted the GH-18 branch August 13, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion proposal exit position always points to the end of proposal
2 participants