This repository has been archived by the owner on Nov 4, 2023. It is now read-only.
Changing dependency for left-pad #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changed dependency to now point at lodash instead of left-pad. This is a more trusted library |
| @@ -1,7 +1,7 @@ | |||
| // Copyright 2014, 2015 Simon Lydell | |||
| // X11 (“MIT”) Licensed. (See LICENSE.) | |||
|
|
|||
| var leftPad = require("left-pad") | |||
| var padStart = require("lodash").padStart | |||
There was a problem hiding this comment.
Maybe instead of the whole library, just this -> https://www.npmjs.com/package/lodash.padstart
There was a problem hiding this comment.
Or you could do require('lodash/padStart').
Since lodash is the most depended on package in npm most have it in their npm cache.
It's essentially free.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left pad deprecated version 0.0.3 and now is using version 0.0.9 . this is causing a dependency fault to babel core, changed version and all tests passed.