Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method of judging amd may cause error:Cannot set property 'Swipe' of undefined #135

Closed
postbird opened this issue May 7, 2020 · 0 comments

Comments

@postbird
Copy link

postbird commented May 7, 2020

Error in:

  if (typeof define === 'function' && define.amd) {
    // AMD. Register as an anonymous module.
    // eslint-disable-next-line no-undef
    define([], function () {
      root.Swipe = factory(); // Cannot set property 'Swipe' of undefined
      return root.Swipe;
    });

somtimes, judgement of define and define.amd may be true, but can not promise that this is an object, it may be undefined, then there will be an error.

suggestion like :

root = root || {} ; // make sure that  root is an object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant