-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an RDS offer #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! The only small thing that'd be nice to see is something testing the reserved_hourly
and reserved_upfront
methods.
It looks like there was a hiccup between on the Github webhook so Travis didn't build this PR. The error was GitHub payload is missing a merge commit (mergeable_state: "unknown", merged: false)
. I closed and re-opened to kick things off again - do you wanna have a look at the mypy
errors in the py3.6 build?
Can you also try the CLA again when you get a chance and let me know if it's working now? If not please send me some more details about what you see and the errors and I'll take a closer look.
Thanks!
|
@@ -114,7 +117,8 @@ def _generate_reverse_sku_mapping(self, | |||
if (product_family is not None and | |||
product['productFamily'] != product_family): | |||
continue | |||
attrs = [product['attributes'][attr] for attr in attribute_names] | |||
attrs = [product['attributes'][attr] | |||
for attr in attribute_names if attr in product['attributes']] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the conditional here to work around the database_edition parameter required to avoid hash collisions; but not always existing for some database engines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks again for contributing! I'll get a release out with this soon
Thanks 👍 I plan to add more in the coming months. |
A few notes about this PR