Add support for Microsoft Azure Compute Resources #554
Conversation
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Conflicts: # cartography/intel/azure/__init__.py # cartography/intel/azure/compute.py # cartography/intel/azure/tenant.py
# Conflicts: # cartography/cli.py # cartography/config.py
# Conflicts: # README.md # setup.py # tests/integration/cartography/data/jobs/test_syntax.py
|
@achantavy Thanks for reviewing the pull request. All the feedback has been incorporated. |
|
@achantavy Updated code to resolve all the comments above. |
setup.py
Outdated
| "python-digitalocean>=1.16.0", | ||
| "PyJWT==1.7.1", |
There was a problem hiding this comment.
Does this need to be pinned? Can it be >=1.7.1 instead?
There was a problem hiding this comment.
azure-cli-core has pinned it to 1.7.1. I tried with >=1.7.1 and it works. But, there's an error notice in logs while installing the dependencies. I did not want to be the cause of someone's CI/CD pipeline failure :)
What do you recommend? @achantavy
There was a problem hiding this comment.
Pin it to 1.7.1 and add a comment on why -- that should be good enough
There was a problem hiding this comment.
@achantavy I have added a comment and pinned the version. Please review and merge.
achantavy
changed the title
This PR is to add initial support of Azure. This intel module currently support only a limited set of Compute related resources like VirtualMachines, DataDisks, Disks and Snapshots. In future, we will extend this furture to include other compute related resources
Currently, the hierarchy is AzureTenant -> AzureSubscription -> VirtualMachine
Also, once reviewed, we want to open pull requests for other resources like Azure Storage, SQL and CosmosDB.