Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add freeform task execution metadata to task executions table #325

Closed
1 of 13 tasks
EngHabu opened this issue May 27, 2020 · 2 comments
Closed
1 of 13 tasks

[Feature] Add freeform task execution metadata to task executions table #325

EngHabu opened this issue May 27, 2020 · 2 comments
Assignees
@katrogan
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers

Comments

@EngHabu
Copy link
Contributor

EngHabu commented May 27, 2020

Motivation: Why do you think this is important?
Allow additional data to be passed as task execution metadata. It's unclear how useful each of these pieces is at the moment but surfacing them might be a good way to figure that out.

Goal: What should the final outcome look like, ideally?
Add execution metadata to task execution events.
An example of this task metadata could be - nodeId for a pod where the node was executed
Cluster id for the hive cluster etc
Qubole Command ID
Resource Token that was associated
podID
AWS Batch Job ID
Spark application id
etc
Thoughts: A simple Map<string,string> called executionMetadata, which we can show as tabular information in the UI
For node name it is part of the podspec - https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.17/#pod-v1-core

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other
@EngHabu EngHabu added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels May 27, 2020
@kumare3
Copy link
Contributor

kumare3 commented Jun 10, 2020

This has to be done in two parts
PART 1: Event has to be updated to add this metadata
PART 2: Update admin to add it to the table and expose it in the API

This was referenced Sep 23, 2020
Merged
Merged
@katrogan
Copy link
Contributor

@EngHabu we already do have https://github.com/flyteorg/flyteidl/blob/da3f0f7695147f79a65f0348ba0f626f054ad28e/protos/flyteidl/event/event.proto#L147 although it is a struct rather than map. this is accessible for calls to get and list task executions https://github.com/flyteorg/flyteidl/blob/master/protos/flyteidl/admin/task_execution.proto#L98

@katrogan katrogan self-assigned this Mar 15, 2021
This was referenced Mar 16, 2021
Merged
Merged
Merged
Merged
@katrogan katrogan closed this as completed Apr 7, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@mayitbeegh
Fix invalid Kubernetes pod names (flyteorg#325)
2d36748 
Signed-off-by: Sean Lin <sean@union.ai>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
@sonjaer
Retry storage operation on 409 conflict (flyteorg#325)
6fa5b48 
* add retry wip

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* add tests

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix lint

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@dependabot
Bump urllib3 in /cookbook/integrations/flytekit_plugins/dolt (flyteor…
a815aea 
…g#325)

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.25.11 to 1.26.5.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.25.11...1.26.5)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Jul 24, 2023
@hamersaw
Supporting DataLoadingConfig on K8sPod type (flyteorg#325)
f0db511 
* supporting data loading config for k8s pod type

Signed-off-by: Daniel Rammer <daniel@union.ai>

* should be checking dataLoadingConfig for nil

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated flyteidl

Signed-off-by: Daniel Rammer <daniel@union.ai>

---------

Signed-off-by: Daniel Rammer <daniel@union.ai>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 9, 2023
@mayitbeegh
Fix invalid Kubernetes pod names (flyteorg#325)
486632d 
Signed-off-by: Sean Lin <sean@union.ai>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@sonjaer
Retry storage operation on 409 conflict (flyteorg#325)
cf76955 
* add retry wip

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* add tests

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>

* fix lint

Signed-off-by: Sonja Ericsson <sonjae@spotify.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@hamersaw
Supporting DataLoadingConfig on K8sPod type (flyteorg#325)
14f46bd 
* supporting data loading config for k8s pod type

Signed-off-by: Daniel Rammer <daniel@union.ai>

* should be checking dataLoadingConfig for nil

Signed-off-by: Daniel Rammer <daniel@union.ai>

* updated flyteidl

Signed-off-by: Daniel Rammer <daniel@union.ai>

---------

Signed-off-by: Daniel Rammer <daniel@union.ai>
troychiu pushed a commit that referenced this issue Jul 8, 2024
@hamersaw
Building task execution context if not exists on fasttask CheckStatus (…
db42532 
…#325)

## Overview
This PR fixes an issue where FlytePropeller restarts and the fasttask plugin checks the status of a task execution where the task execution context does not exist. Rather than fail, it creates the task execution context (that will be cleaned up later) and returns running.

## Test Plan
This was tested locally under a variety of failure scenarios.

## Rollout Plan (if applicable)
This may be rolled out immediately.

## Upstream Changes
Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F).
- [ ] To be upstreamed to OSS

## Issue
https://linear.app/unionai/issue/COR-1128/fasttask-plugin-checks-status-of-task-execution-failure-on-restart

## Checklist
* [x] Added tests
* [ ] Ran a deploy dry run and shared the terraform plan
* [ ] Added logging and metrics
* [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list)
* [ ] Updated documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katrogan katrogan

Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EngHabu @katrogan @kumare3