Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waitUntilHittable never waits? #8

Closed
toshi0383 opened this issue Jul 15, 2021 · 1 comment · Fixed by #6
Closed

waitUntilHittable never waits? #8

toshi0383 opened this issue Jul 15, 2021 · 1 comment · Fixed by #6
Assignees
@gabriellanata
Labels
bug Something isn't working

Comments

@toshi0383
Copy link

Hi from Japan👋🏻
I see waitUntilHittable in testcases a lot, but it seems like self.defaultTouchLocation is never nil or throws error, so what is the point?
@gabriellanata
Copy link
Contributor

gabriellanata commented Jul 15, 2021 •
edited
Loading

You're right! That was a mistake when copying it over from our internal repo into the open source one. Submitting a fix that completely removes self.defaultTouchLocation to avoid accidental issues like this.

@gabriellanata gabriellanata self-assigned this Jul 15, 2021
@gabriellanata gabriellanata added the bug Something isn't working label Jul 15, 2021
@gabriellanata gabriellanata linked a pull request Jul 15, 2021 that will close this issue
Improve hit test methods #6
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabriellanata gabriellanata

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve hit test methods lyft/Hammer
2 participants
@gabriellanata @toshi0383