This repository has been archived by the owner on May 17, 2024. It is now read-only.
Fix Float mapping with downcasting #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior of `NSNumber as? Float` in Swift is such that some values that cannot "safely express the value stored" in NSNumber. This means only using `as?` to cast to `Float` can fail, where doing `.floatValue` or `Float.init` would succeed. To work around this oddity, this new `Convertible` conformance calls `.floatValue` on `NSNumber`, leading to a float, that is possibly less precise than you'd like.
sberrevoets
approved these changes
Jul 31, 2018
pgherveou
approved these changes
Jul 31, 2018
dduan
approved these changes
Jul 31, 2018
Reflejo
approved these changes
Jul 31, 2018
rebello95
approved these changes
Jul 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
NSNumber as? Floatin Swift is such that some valuesthat cannot "safely express the value stored" in NSNumber. This means
only using
as?to cast toFloatcan fail, where doing.floatValueor
Float.initwould succeed. To work around this oddity, this newConvertibleconformance calls.floatValueonNSNumber, leading toa float, that is possibly less precise than you'd like.