Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respond to CTCP PING requests ;) #37

Closed
ghost opened this issue Jun 28, 2014 · 2 comments
Closed

Respond to CTCP PING requests ;) #37

ghost opened this issue Jun 28, 2014 · 2 comments
Labels
enhancement

Comments

@ghost
Copy link

ghost commented Jun 28, 2014

It might be nice if lykos responded to CTCP PING requests, to allow players to test their connection lag to the bot. That way, a player can easily find out how long it takes until lykos receives a command from them.
@ghost ghost added the enhancement label Jul 2, 2014
@ghost
Copy link

ghost commented Jul 2, 2014

I'm not sure how to implement this, because Oyoyo's hook system looks weird.

For the record, !ping in the middle of a game and /msg lykos ping will reply with Pong!.

Transfusion added a commit to Transfusion/lykos that referenced this issue Jul 15, 2014
@Transfusion
Enable CTCP PING as per issue lykoss#37
ae64979
ghost pushed a commit that referenced this issue Jul 15, 2014
@qtlunya
Merge pull request #41 from Transfusion/enable_ctcp_ping
91e597d 
Enable CTCP PING as per issue #37
@ghost
Copy link
Author

ghost commented Jul 15, 2014

awesome, thanks :D
Works perfectly as it should.

@ghost ghost closed this as completed Jul 15, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants