Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createRoom from ruby client fails on cleanup branch #32

Closed
robomon1 opened this issue Sep 14, 2013 · 1 comment
Closed

createRoom from ruby client fails on cleanup branch #32

robomon1 opened this issue Sep 14, 2013 · 1 comment

Comments

@robomon1
Copy link

Changes to roomsResource.js on line 35 on the cleanup branch breaks the ruby client when calling createRoom. options is not passed in the body so it fails testing the req.body.options.test property as options is undefined. Not sure if this should be fixed by updating the ruby client to set an empty options in the body of the request (tested and fixes the issue) or to test for options in roomsResource.js before testing for the test property.

2.0.0-p195 :012 > test2.createRoom('roomfail')
 => "TypeError: Cannot read property 'test' of undefined\n    at exports.createRoom
 (/var/lib/licode/nuve/nuveAPI/resource/roomsResource.js:35:25)\n    at callbacks 
(/var/lib/licode/node_modules/express/lib/router/index.js:164:37)\n    at param 
(/var/lib/licode/node_modules/express/lib/router/index.js:138:11)\n    at pass 
(/var/lib/licode/node_modules/express/lib/router/index.js:145:5)\n    at nextRoute 
(/var/lib/licode/node_modules/express/lib/router/index.js:100:7)\n    at callbacks 
(/var/lib/licode/node_modules/express/lib/router/index.js:167:11)\n    at 
/var/lib/licode/nuve/nuveAPI/auth/nuveAuthenticator.js:96:17\n    at 
/var/lib/licode/nuve/nuveAPI/mdb/serviceRegistry.js:27:13\n    at Cursor.nextObject 
(/var/lib/licode/node_modules/mongodb/lib/mongodb/cursor.js:678:5)\n    at 
commandHandler 
(/var/lib/licode/node_modules/mongodb/lib/mongodb/cursor.js:658:14)" 
@aalonsog
Copy link
Member

The solution is the first one, I've just updated the ruby client including "options" param. Thank you!

jcague pushed a commit to jcague/licode that referenced this issue Feb 21, 2017
Merge ging:master to development
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants