-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ponder support #481
Closed
Closed
Add ponder support #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue with original impl detecting score 0 |
…ame instance before search after ponder hit
Issue with 0f440ca: |
Merged
Closing in favor of #772 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ponder enabled vs no pondering 👎🏽👎🏽
Regression: disabled vs no pondering
So at least just need to fix the pondering behavior, but when it's off the perf isn't affected
Fix pondering: save previous position command and use it to restore Game instance before search after ponder hit
0f440ca
Remove special ponder hit treatment
and
Make sure to cancel ponder search on new game and avoid fake ponder h…Finished game 235 (Lynx-add-ponder-support-1950-win-x64 vs Lynx-add-ponder-support-1948-win-x64): 1-0 {White mates}
cutechess crashes
Try again ponder hit logic of reusing killers and not deleting history