Print children in json, even if output:list is enabled #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Children structure is pretty useful, especially for NVMe disks. It is pretty hard to track which namespace belongs to which disk without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When output:list is enabled, the json output shows the children structure before commit 1556522, but this behavior was changed after the commit.
I don't know if this is intended, but I think that children structure is pretty useful, especially for NVMe disks.
It is pretty hard to track which namespace belongs to which disk without showing the structure.
If not printing children is intended behavior, I would suggest give an extra option to change output:list to false even when pass
-c <class>argument.