Implements HTTPS support for hieraserver #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flashvoid
force-pushed
the
feature/tls
branch
from
1b28bac
to
1cf5236
Compare
flashvoid
force-pushed
the
feature/tls
branch
from
1cf5236
to
03f3841
Compare
thallgren
suggested changes
Jan 13, 2020
hieraserver/rest/rest.go
Outdated
|
|
||
| var err error | ||
| var tlsConfig *tls.Config | ||
| tlsConfig, err = makeTLSconfig() |
There was a problem hiding this comment.
Please skip preceding var declarations and use :=.
hieraserver/rest/rest.go
Outdated
| certPool := x509.NewCertPool() | ||
| ok := certPool.AppendCertsFromPEM(data) | ||
| if !ok { | ||
| return nil, fmt.Errorf("Failed to load certificate %s", pemFile) |
There was a problem hiding this comment.
Please use %q to quote the path as it's not uncommon that it contains spaces.
thallgren
approved these changes
Jan 13, 2020
ahpook
pushed a commit
to ahpook/gohiera
that referenced
this pull request
Jan 16, 2020
Prior to this commit, changes in lyraproj#60 caused an initialized but non-functional tlsConfig object to skip the non-SSL listener startup, which would fail. There might be a more sophisticated fix, but this wfm... Fixes lyraproj#62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I suggest enabling hieraserver to run in HTTPS configuration since it is likely to be serving secrets.