Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli.py): Add ability to glob on directories #215

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

Rizhiy
Copy link
Contributor

@Rizhiy Rizhiy commented Jan 26, 2023

Ability to glob on directories

Fixes #162, Fixes #205

After checking the behaviour of black and isort, I see that they don't actually glob on no arguments, so I replicated the behaviour here.

yamlfix . should work now.

Checklist

  • Add test cases to all the changes you introduce
  • Update the documentation for the changes

@coveralls
Copy link

coveralls commented Jan 26, 2023

Pull Request Test Coverage Report for Build 4012054258

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 27 of 27 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 99.784%

Totals Coverage Status
Change from base Build 4007509205: 0.01%
Covered Lines: 462
Relevant Lines: 463

💛 - Coveralls

@Rizhiy Rizhiy changed the title feat(cli.py): Add ability to glob on directories (WIP) feat(cli.py): Add ability to glob on directories Jan 26, 2023
@Rizhiy
Copy link
Contributor Author

Rizhiy commented Jan 26, 2023

Don't merge yet, I realised that there is a way to simplify logic a bit, will implement tomorrow.

@Rizhiy Rizhiy changed the title (WIP) feat(cli.py): Add ability to glob on directories feat(cli.py): Add ability to glob on directories Jan 27, 2023
@Rizhiy
Copy link
Contributor Author

Rizhiy commented Jan 29, 2023

@lyz-code Hi, ready for merge now.

Copy link
Owner

@lyz-code lyz-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! thanks for your contribution

@lyz-code lyz-code merged commit 9919083 into lyz-code:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make yamlfix find all yaml files recursively by default Run yamlfix for multiple files
3 participants