Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yamlfix 217 #219

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Yamlfix 217 #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
956c319
Ran yamlfix . against repo
Jan 31, 2023
b88ecfe
Adding yamllint to pipelines
Jan 31, 2023
958e381
Fix yamllint
Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
---
name: Build

on: # yamllint disable-line rule:truthy
push:
branches:
- main
branches: [main]
workflow_dispatch:

jobs:
PyPI:
name: Build and publish Python distributions to TestPyPI
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ on: # yamllint disable-line rule:truthy
schedule:
- cron: 21 08 * * *
workflow_dispatch:

jobs:
Install:
runs-on: ubuntu-latest
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
---
name: Tests

on: # yamllint disable-line rule:truthy
push:
branches: [main]
pull_request:
types: [opened, synchronize]
workflow_dispatch:

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line length should be changed by yamlfix too. Look at the docs. Maybe it's a bug that it's not cropping it well

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't feel like debugging the issue with the cropping, you can do it manually, but I wouldn't increase the line length either in yamlfix or in yamllint

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, it must be a bug. I even tried setting that specifically and it did not work

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed the bug and opened a new issue to track it. I'd say it's better to manually fix these comments so that we can merge the PR. What do you think?

jobs:
Tests:
runs-on: ubuntu-latest
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ on: # yamllint disable-line rule:truthy
schedule:
- cron: 11 7 * * *
workflow_dispatch:

jobs:
Update:
runs-on: ubuntu-latest
Expand Down
3 changes: 1 addition & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ repos:
- name: Run mypy static analysis tool
id: mypy
files: src
additional_dependencies:
- pydantic
additional_dependencies: [pydantic]
args:
- --no-warn-unused-ignores
- --ignore-missing-imports
Expand Down
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ lint:
pdm run flakeheaven lint src/ tests/
$(isort) --check-only --df
$(black) --check --diff
yamllint .
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use yamlfix --check instead

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh! Good idea!


@echo ""

Expand Down
6 changes: 0 additions & 6 deletions mkdocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ nav:
- Editor Integration: editor_integration.md
- Reference: reference.md
- Contributing: contributing.md

plugins:
- search
- mkdocstrings:
Expand All @@ -24,7 +23,6 @@ plugins:
- minify:
minify_html: true
- section-index

markdown_extensions:
- abbr
- def_list
Expand Down Expand Up @@ -58,7 +56,6 @@ markdown_extensions:
- pymdownx.tasklist:
custom_checkbox: true
- pymdownx.tilde

theme:
name: material
custom_dir: docs/theme
Expand All @@ -68,12 +65,9 @@ theme:
- navigation.footer
- navigation.top
- content.code.annotate

palette:
primary: blue grey
accent: light blue

extra_css: [stylesheets/extra.css, stylesheets/links.css]

repo_name: lyz-code/yamlfix
repo_url: https://github.com/lyz-code/yamlfix