-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix block scalar mangling bug #231 #232
Open
wrouesnel
wants to merge
1
commit into
lyz-code:main
Choose a base branch
from
wrouesnel:fix_block_whitespace_handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
"""Define utility helpers.""" | ||
from typing import Any, Callable, Iterable, Mapping | ||
|
||
|
||
def walk_object( | ||
target: Any, callback_fn: Callable[[Any], None] # noqa: ANN401 | ||
) -> None: | ||
"""Walk a YAML/JSON-like object and call a function on all values.""" | ||
callback_fn(target) # Call the callback and whatever we received. | ||
|
||
if isinstance(target, Mapping): | ||
# Map type | ||
for _, value in target.items(): | ||
walk_object(value, callback_fn) | ||
elif isinstance(target, Iterable) and not isinstance(target, (bytes, str)): | ||
# List type | ||
for value in target: | ||
walk_object(value, callback_fn) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -469,7 +469,7 @@ def test_fix_code_functions_emit_debug_logs( | |
|
||
fix_code("") # act | ||
|
||
expected_logs = { | ||
expected_logs = { # noqa: W0130 | ||
"Setting up ruamel yaml 'quote simple values' configuration...", | ||
"Setting up ruamel yaml 'sequence flow style' configuration...", | ||
"Running ruamel yaml base configuration...", | ||
|
@@ -481,6 +481,14 @@ def test_fix_code_functions_emit_debug_logs( | |
"Restoring jinja2 variables...", | ||
"Restoring double exclamations...", | ||
"Fixing comments...", | ||
# Fixing comments causes a re-run of fixers, so we get duplicates from here | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't like the re-running of previous fixers, can't you fix comments before so that we don't have to rerun everything? I think it is really bad from the point of view of the performance of the tool to do this. |
||
"Fixing truthy strings...", | ||
"Fixing jinja2 variables...", | ||
"Running ruamel yaml fixer...", | ||
"Restoring truthy strings...", | ||
"Restoring jinja2 variables...", | ||
"Restoring double exclamations...", | ||
# End fixing comments duplicates | ||
"Fixing top level lists...", | ||
"Fixing flow-style lists...", | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
fixed_source
==source
I think it will be cleaner to useresult == source
. If they are different I was not able to tell them apart :S