Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024_07: BUG: PROD team data upload is inconsistent via DDD #3220

Closed
ljmoody opened this issue Jul 18, 2024 · 28 comments
Closed

2024_07: BUG: PROD team data upload is inconsistent via DDD #3220

ljmoody opened this issue Jul 18, 2024 · 28 comments
Assignees
Labels
bug These are problems associated with technologies that need to be fixed right away. Development Value stream activities in support of technological development. sim ui dev alert from James to Tejas that issues are ready to be worked on by dev sim_ui #sim_ui_workflow includes modeling
Milestone

Comments

@ljmoody
Copy link
Collaborator

ljmoody commented Jul 18, 2024

*may be related to #3216.

Discovered 7/18/2024 by Jenn and Laura in PROD instance, both Edge and Chrome browsers.
Uploading team data files via the Admin Dashboard and the DDD is highly inconsistent today.

When attempting to upload or add a team data file to a team in PROD via the Admin Dashboard we observed the following on different attempts:

  • the "thinking" ellipses just keep going and file is not uploaded or added
    image

  • the file was added

  • the green success message indicated data file was uploaded, but the data file did not show in the Settings > Data list, nor was it available to select from the DDD Session Start & Team Data windows

  • the file was uploaded...but to multiple teams, not the one specified

    • Example: I uploaded a data file and selected it to go into 123_demo_sim_ind:
      image

    • ...but the file was uploaded to two teams:
      image

@ljmoody ljmoody added sim_ui #sim_ui_workflow includes modeling sim ui dev alert from James to Tejas that issues are ready to be worked on by dev bug These are problems associated with technologies that need to be fixed right away. Development Value stream activities in support of technological development. labels Jul 18, 2024
@ljmoody ljmoody added this to the 2024_07 milestone Jul 18, 2024
@lijenn
Copy link
Collaborator

lijenn commented Jul 19, 2024

Discussed 7/19 Team Praxis Call:

@matthewtomo
Copy link
Collaborator

matthewtomo commented Jul 22, 2024

Bug experienced during 7/22 Support Systems SME and Sim UI Workflows Meeting. Attached is a screenshot of the issue occurring with errors shown in console.

File uploaded successfully, but when attempting to start a session, the ellipses loading indicator continued without stopping for 15+ minutes in PROD.

image

@tejaspesquare

fyi: @jamesmrollins @lijenn @ljmoody @dlounsbu @dlkibbe

@lzim
Copy link
Owner

lzim commented Jul 23, 2024

Let's keep a very close eye on the related cards as we prep these consults for scheduling wk2 2024_08.
Thanks for the hard work, everyone!

@ljmoody ljmoody assigned matthewtomo and unassigned matomasz Jul 24, 2024
@matthewtomo
Copy link
Collaborator

Discussed support_workflow
@ljmoody @lijenn @matthewtomo

@lzim @jamesmrollins @tejaspesquare

@matthewtomo
Copy link
Collaborator

Discussed 7/25 Standup with Dev
@matthewtomo @tejaspesquare

  • During testing last night with @ljmoody, @lijenn, and @matthewtomo, we ran into strange behavior when I attempted to add myself as a team lead when already an administrator. This removed my administrator access, and I could no longer see the group on the admin dashboard and could only access the team's DDD. Is this the desired bahavior? and Should administrators be allow to downgrade themselves in this way?. @tejaspesquare was asking if we should prevent an admin from downgrading themselves in this way.
  • The Image below is a table tracking the current behaviors in the DEV branch for the SIM UI. (3 missing rows will be updated once testing is finished)

image

@tejaspesquare
Copy link
Collaborator

Hello @jamesmrollins , @ljmoody , @lijenn , @matthewtomo

I proceeded with testing on the Dev branch for the Team setup, addressing the remaining 3 use cases that were pending from yesterday's execution. Please review the most recent outcome.

Dev_SIMUI_Team Setup_25-26July

Furthermore, we have also addressed a scenario where the user configures a team without adding any members.
Note: The default lead user is loaded at the beginning itself, unlike this user added to 3 worlds after pressing Done.
image

Kindly provide confirmation regarding the use case mentioned by @matthewtomo above, specifically case about the possibility of allowing a logged-in Admin user to downgrade to Team Lead while performing team setup. If this scenario is likely possible then additional time (POC + Development) will be needed to address it. Furthermore, there are also anticipated changes on the Forio side too. If not, we will restrict user from doing it.

Thanks!

@matthewtomo
Copy link
Collaborator

Discussed DEV Standup 7/29/2024
@matthewtomo @tejaspesquare

  • @matthewtomo will verify that team lead and other default users are being added automatically in DEV branch.
  • Dev team needs clarification on whether or not a facilitator should be able to downgrade themselves:

During testing last night with @ljmoody, @lijenn, and @matthewtomo, we ran into strange behavior when I attempted to add myself as a team lead when already an administrator. This removed my administrator access, and I could no longer see the group on the admin dashboard and could only access the team's DDD. Is this the desired bahavior? and Should administrators be allow to downgrade themselves in this way?. @tejaspesquare was asking if we should prevent an admin from downgrading themselves in this way.

fyi: @jamesmrollins @lijenn @ljmoody

@ljmoody
Copy link
Collaborator Author

ljmoody commented Jul 29, 2024

@matthewtomo, I tested in DEV instance, Chrome browser, using VA laptop.

Test 1:

  • created a new team, did not manually add any users
    image
  • all 3 worlds were created
    image
  • Default Team Lead is added to teams automatically upon setup
  • 6 default users were not added
    image
    image
    image

Test 2:

  • created a new team, manually added 1 user
    image
  • all 3 worlds were created
    image
  • Default Team Lead was added to teams automatically upon setup
  • Manually added member shows in _ind and _team worlds
    image
    image
    image

@ljmoody
Copy link
Collaborator Author

ljmoody commented Jul 29, 2024

@matthewtomo, I tested in TEST instance, Chrome browser, using VA laptop. Logged in as an Administrator.

Test 1:

  • created a new team, did not manually add any users

  • _shared world was not created/is not visible:
    image

  • 6 auto-added users were added

  • no Default Team Lead dummy account was added

  • did not expect to see Roshan shah on the team
    image
    image

Test 2:

  • created a new team, manually added 1 user. Forced to add 2, so there was a team lead. No Default Team Lead user was automatically added when team was created:
    image

  • all 3 worlds were created
    image

  • Default Team Lead was added to teams after I designated a team lead (see above, was forced to do that for team creation)

  • 6 auto-added users were added to all teams

  • did not expect to see Roshan shah on the team
    image
    image
    image

@tejaspesquare
Copy link
Collaborator

Hello @ljmoody

@matthewtomo, I tested in TEST instance, Chrome browser, using VA laptop. Logged in as an Administrator.

As we anticipate new developments regarding Team Setup transitioning from Development to Testing and subsequently to Production, following the validation of all use cases, it is advisable to refrain from conducting tests in the Testing environment at this time.
Thanks!

@tejaspesquare
Copy link
Collaborator

tejaspesquare commented Jul 30, 2024

Hello @ljmoody

Test 1:

  • created a new team, did not manually add any users
  • all 3 worlds were created
  • Default Team Lead is added to teams automatically upon setup
  • 6 default users were not added

Thanks for sharing your test result. Regarding your concern "6 default users were not added",

Result you have noticed is expected one on Dev instance. We have not configured all users in our local instance.
image

FYI - @jamesmrollins , @lijenn , @matomasz

@tejaspesquare tejaspesquare reopened this Jul 30, 2024
@tejaspesquare
Copy link
Collaborator

tejaspesquare commented Jul 30, 2024

Hello @ljmoody, @lijenn, @matomasz

Just FYI - Currently, we have set up all default users for the Development instance to facilitate your testing.
image

@ljmoody
Copy link
Collaborator Author

ljmoody commented Jul 30, 2024

@matthewtomo, FYI:
Tested in DEV instance this morning, Chrome browser, on VA laptop, with VA login as administrator.

Test 1: no users added during team creation

image

  • all auto-added members are present, as well as Default Team Lead
    image

Test 2: 2 users added during team creation

image

  • all auto-added members are present, as well as Default Team Lead
    image

@tejaspesquare
Copy link
Collaborator

tejaspesquare commented Jul 31, 2024

Hello @ljmoody, @lijenn, @matomasz,

Team Setup & Team Data Upload via DDD: could you please inform us once you are done with the execution on Dev instance of all use cases regarding Team Setup. We will prepare for code migration up to production.

Team Data Upload via DDD:

Uploading
image

After Deleting
image
image

Note: Team Data upload via Admin Dashboard too fixed but checking for delete operation. Once this is covered, we will make available for your testing.

@matthewtomo
Copy link
Collaborator

@tejaspesquare

  • It looks like most of our expected members of the default member list are being added upon team creation (including the default team lead).
  • There was one extra person added (Roshan shah). We would like this account to not be included in the default members list.
  • There is one missing person we would like to have added (Matthew Tomaszewski, mtomas@praxisanalytix.com).

Additional question:

  • Is there a reason why we are currently testing in the DEV branch as opposed to the TEST branch?

@tejaspesquare
Copy link
Collaborator

Hi @matthewtomo,

We have added Default users (live) into DEV instance just to support for your execution & extra person (Roshan Shah) is our internal user. For time being we will make changes as requested (Remove Roshan Shah & Adding Matthew Tomaszewski).

Additional question:

  • Is there a reason why we are currently testing in the DEV branch as opposed to the TEST branch?

So far, Team Setup issues have been resolved according to each specific request, however, we were unaware of the complete set of business rules. Therefore, we aimed to establish a stable version that aligns with the requirements.

@tejaspesquare
Copy link
Collaborator

Hello @ljmoody, @lijenn, @matthewtomo,

Would it be acceptable to everyone if we proceed with migrating the code related to the Team setup and the Inconsistency DDD Team Data file to the TEST environment?

@tejaspesquare
Copy link
Collaborator

Hello @ljmoody, @lijenn, @matomasz,

Note: Team Data upload via Admin Dashboard too fixed but checking for delete operation. Once this is covered, we will make available for your testing.

This is fixed & can be verified on Dev instance.

Uploaded Fiel in 2 different Groups
image

Uploading fresh file other than above two groups, previously selected groups is not affected as expected
image

@matthewtomo
Copy link
Collaborator

Discussed in DEV Standup 8/1/2024
@matthewtomo @tejaspesquare

  • @matthewtomo checked today, and the Behavior in DEV is now working as expected.
  • @tejaspesquare will deploy updates to the TEST branch and notify here once completed.

fyi: @jamesmrollins @lijenn @ljmoody

@tejaspesquare
Copy link
Collaborator

Hello @jamesmrollins , @ljmoody , @lijenn , @matomasz ,

Kindly be advised that the migration of code from the Development environment to the TEST environment has been successfully accomplished.

@ljmoody
Copy link
Collaborator Author

ljmoody commented Aug 2, 2024

8/2/24 update from Tejas:

@lijenn lijenn modified the milestones: 2024_07, 2024_08 Aug 5, 2024
@ljmoody
Copy link
Collaborator Author

ljmoody commented Aug 5, 2024

8/5/24 user testing in TEST instance for #3220 & 3216.
fyi @matthewtomo - esp. step 4. And FYI: I wasn't able to test in Edge because of time constraints.

Chrome UX:

  1. Logged on with VA account, administrator_login.
  2. Created a new team: 3216_3220_chrome (did not manually add any users).
  3. Uploaded a data file via Settings>Data>Add>Upload:
    image
    SIDE QUESTION: if a user uploads a data file to a _team world, should that data file be uploaded to _team, _shared, and _ind?
  4. Team was not listed under Select Team dropdown in Administrator Dashboard.
  5. Refreshed browser. Now my team is available to select. Navigated to team's Home Page:
    image
  6. Data file is showing in both expected places:
    image
  7. I was able to run the data file; all 5 modules initialized.
    image
  8. Uploaded a second data set to the same team - this time via DDD's Team Data window:
    image
  9. Confirmed that the data file is immediately available in both expected places (and returned same DDD results when run):
    image

@lijenn
Copy link
Collaborator

lijenn commented Aug 5, 2024

^ Whoops! We might have been testing at the same time @ljmoody! Despite getting the green pop-up saying my data file was successfully uploaded, I am unable to see the data file show up in my dropdown list for my 2 teams in test, #3203_test2_chrome_jenn_2024_08_05 and #3203_chrome_jenn_2024_08_05:

I got these console logs in Chrome, but not sure if it's helpful since only one person can do testing at a time.

Leaving them here in case it's helpful (seems like it would be expected since I'm seeing time out logs that's probably coming from ANDON #3232?) and I will test this evening again:
image
image
image

FYI @matomasz

@tejaspesquare
Copy link
Collaborator

@ljmoody, @lijenn, @matomasz,

FYI - The error message "episodes did not create" on the Admin Dashboard has been resolved in the DEV and TEST environments. Once the code is deployed to the PROD environment, this issue will no longer be present.

  • Our analysis indicates that this issue is occurring in the production (current) environment due to the absence of the Team Lead in the SIM UI group (on Epicenter Lead is present).

@matthewtomo
Copy link
Collaborator

@dlkibbe @dlounsbu It looks like you might want to push back the work session, as not all of the changes are ready to go through.

@matthewtomo
Copy link
Collaborator

Tested 8/9/2024 on Non VA machine

  • Files uploaded successfully and showed up promptly with no issue
  • Ready for PROD

Chrome:

image
image

Edge:

image
image

@matthewtomo
Copy link
Collaborator

Discussed 8/20/2024
@matthewtomo @jamesmrollins @lijenn

  • @matthewtomo will investigate the inconsistencies in the Admin Dashboard

@matthewtomo matthewtomo changed the title 2024_07: BUG: PROD team data upload is inconsistent via Admin Dash & DDD 2024_07: BUG: PROD team data upload is inconsistent via DDD Aug 23, 2024
@matthewtomo
Copy link
Collaborator

week 3 2024_08 Praxis Meeting
@matthewtomo @jamesmrollins @ljmoody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug These are problems associated with technologies that need to be fixed right away. Development Value stream activities in support of technological development. sim ui dev alert from James to Tejas that issues are ready to be worked on by dev sim_ui #sim_ui_workflow includes modeling
Projects
Status: closed
Development

No branches or pull requests

7 participants