-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add yesterday functionality #287
Conversation
f3596da
to
67afc15
Compare
67afc15
to
4f3768f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @gfr10598 and @stephen-soltesz)
job-service/job-service.go, line 86 at r1 (raw file):
// Recover the date from datastore. ctx, cf := context.WithTimeout(context.Background(), 5*time.Second)
nit: I'd recommend passing in the context. It looks like NewJobService
is already allocating one context for another function. Putting the call there will make it easier to provide a context from main (or whatever is one level up).
Right now we have a bunch of random background contexts for functions doing complex things at lower levels.
504bb23
to
d44229b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @stephen-soltesz)
job-service/job-service.go, line 86 at r1 (raw file):
Previously, stephen-soltesz (Stephen Soltesz) wrote…
nit: I'd recommend passing in the context. It looks like
NewJobService
is already allocating one context for another function. Putting the call there will make it easier to provide a context from main (or whatever is one level up).Right now we have a bunch of random background contexts for functions doing complex things at lower levels.
Added ctx injection here and in other places.
d44229b
to
fe12338
Compare
This completes the implementation of processing of yesterday's data at 0600 UTC.
This change is