Embed a static git commit hash in the gardener binary #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertodauria
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
robertodauria
approved these changes
Mar 1, 2021
|
The command to read the local Ultimately, I'd like to populate this with either the branch (for sandbox and staging) or the tag (prod). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, etl-gardener reads the "GIT_COMMIT" value from its runtime environment, which could be out of sync with reality. This change embeds the real git commit as a static variable at build time.
This change simplifies configuration and supports an effort to migrate the gardener deployment to cloudbuild.
This change is