Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row count and error meta-data to json output files #937

Merged
merged 3 commits into from
Aug 13, 2020

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented Aug 12, 2020

This will allow future use of the meta-data by gardener to ensure that the data has been correctly parsed and loaded.


This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Aug 12, 2020

Pull Request Test Coverage Report for Build 6152

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.582%

Totals Coverage Status
Change from base Build 6147: 0.0%
Covered Lines: 3142
Relevant Lines: 4719

💛 - Coveralls

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @stephen-soltesz)

@gfr10598 gfr10598 merged commit eb611b0 into master Aug 13, 2020
@gfr10598 gfr10598 deleted the u-sandbox-meta-data branch August 13, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants