-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move testutil to new go repository #1
Conversation
Changes Unknown when pulling 7be9b7a on testutil into ** on master**. |
Changes Unknown when pulling 505feca on testutil into ** on master**. |
Reviewed 1 of 6 files at r1, 5 of 5 files at r2. .travis.yml, line 9 at r2 (raw file):
Let's try the service-account-as-environment-variables approach this time. i.e. https://github.com/m-lab/travis/blob/master/setup_service_accounts_for_travis.sh README.md, line 6 at r2 (raw file):
With the advent of scrumdo what will be our relationship with waffle.io going forward? Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions. .travis.yml, line 9 at r2 (raw file): Previously, stephen-soltesz (Stephen Soltesz) wrote…
Ack - I'm doing that in the next PR. README.md, line 6 at r2 (raw file): Previously, stephen-soltesz (Stephen Soltesz) wrote…
Ack. Don't know. Will fix when we do. Comments from Reviewable |
Reviewed 1 of 6 files at r1, 5 of 5 files at r2. Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions. .travis.yml, line 9 at r2 (raw file): Previously, gfr10598 (Gregory Russell) wrote…
Done. README.md, line 6 at r2 (raw file): Previously, gfr10598 (Gregory Russell) wrote…
Done. Comments from Reviewable |
OK Review status: all files reviewed at latest revision, 2 unresolved discussions. Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions. Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions. Comments from Reviewable |
LGTM Comments from Reviewable |
Please also review the overall README file.
We may want to put more effort into the API and documentation. Not sure whether to do that first, or get something checked in and iterate.
This change is