Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move testutil to new go repository #1

Merged
merged 4 commits into from
Dec 6, 2017
Merged

Move testutil to new go repository #1

merged 4 commits into from
Dec 6, 2017

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented Dec 5, 2017

Please also review the overall README file.

We may want to put more effort into the API and documentation. Not sure whether to do that first, or get something checked in and iterate.


This change is Reviewable

@coveralls
Copy link
Collaborator

Coverage Status

Changes Unknown when pulling 7be9b7a on testutil into ** on master**.

@coveralls
Copy link
Collaborator

Coverage Status

Changes Unknown when pulling 505feca on testutil into ** on master**.

@gfr10598 gfr10598 self-assigned this Dec 6, 2017
@stephen-soltesz
Copy link
Contributor

:lgtm:


Reviewed 1 of 6 files at r1, 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


.travis.yml, line 9 at r2 (raw file):

# credentials.
#Z
#  * decrypt service account credentials

Let's try the service-account-as-environment-variables approach this time.

i.e. https://github.com/m-lab/travis/blob/master/setup_service_accounts_for_travis.sh


README.md, line 6 at r2 (raw file):

| master | [![Travis Build Status](https://travis-ci.org/m-lab/go.svg?branch=master)](https://travis-ci.org/m-lab/go) | [![Coverage Status](https://coveralls.io/repos/m-lab/go/badge.svg?branch=master)](https://coveralls.io/github/m-lab/go?branch=master) |

[![Waffle.io](https://badge.waffle.io/m-lab/go.svg?title=Ready)](http://waffle.io/m-lab/go)

With the advent of scrumdo what will be our relationship with waffle.io going forward?


Comments from Reviewable

@gfr10598
Copy link
Contributor Author

gfr10598 commented Dec 6, 2017

Review status: all files reviewed at latest revision, 2 unresolved discussions.


.travis.yml, line 9 at r2 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…

Let's try the service-account-as-environment-variables approach this time.

i.e. https://github.com/m-lab/travis/blob/master/setup_service_accounts_for_travis.sh

Ack - I'm doing that in the next PR.


README.md, line 6 at r2 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…

With the advent of scrumdo what will be our relationship with waffle.io going forward?

Ack. Don't know. Will fix when we do.


Comments from Reviewable

@gfr10598
Copy link
Contributor Author

gfr10598 commented Dec 6, 2017

Reviewed 1 of 6 files at r1, 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

@gfr10598
Copy link
Contributor Author

gfr10598 commented Dec 6, 2017

Review status: all files reviewed at latest revision, 2 unresolved discussions.


.travis.yml, line 9 at r2 (raw file):

Previously, gfr10598 (Gregory Russell) wrote…

Ack - I'm doing that in the next PR.

Done.


README.md, line 6 at r2 (raw file):

Previously, gfr10598 (Gregory Russell) wrote…

Ack. Don't know. Will fix when we do.

Done.


Comments from Reviewable

@gfr10598
Copy link
Contributor Author

gfr10598 commented Dec 6, 2017

OK


Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

@stephen-soltesz
Copy link
Contributor

:lgtm:


Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

@stephen-soltesz
Copy link
Contributor

:lgtm_strong:


Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

@gfr10598
Copy link
Contributor Author

gfr10598 commented Dec 6, 2017

LGTM


Comments from Reviewable

@gfr10598 gfr10598 removed their assignment Dec 6, 2017
@gfr10598 gfr10598 merged commit bcef4e7 into master Dec 6, 2017
@gfr10598 gfr10598 deleted the testutil branch December 6, 2017 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants