Version metrics

[pboothe]

This change is 

[coveralls]

Pull Request Test Coverage Report for Build 368

• 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.5%) to 71.48%

---

Totals
Change from base Build 366:	0.5%
Covered Lines:	396
Relevant Lines:	554

---

💛 - Coveralls

[stephen-soltesz]

One specific change, looks good otherwise.

Reviewed 1 of 4 files at r1.
Reviewable status: 0 of 1 LGTMs obtained

---

prometheusx/prom.go, line 47 at r1 (raw file):

	number, err := strconv.ParseInt(commit, 16, 64)
	if err == nil {
		gitShortCommitMetric.Set(float64(number))

Please add the commit as a label also. In Grafana it will be possible to extract that label and turn it into a link. Indeed, if we have two commit labels from different versions we can even construct a URL to github the shows us the diff. I don't think I know how to achieve the same thing with the value alone.

---

prometheusx/prom.go, line 49 at r1 (raw file):

		gitShortCommitMetric.Set(float64(number))
	} else {
		gitShortCommitMetric.Set(0)

nit: is 0000000 a valid git commit short hash?

[pboothe]

Reviewable status: 0 of 1 LGTMs obtained

---

prometheusx/prom.go, line 47 at r1 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…

Please add the commit as a label also. In Grafana it will be possible to extract that label and turn it into a link. Indeed, if we have two commit labels from different versions we can even construct a URL to github the shows us the diff. I don't think I know how to achieve the same thing with the value alone.

Done.

---

prometheusx/prom.go, line 49 at r1 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…

nit: is 0000000 a valid git commit short hash?

Yup, but very unlikely. If this bites us, please say "I told you so"

[stephen-soltesz]

Reviewable status: complete! 1 of 1 LGTMs obtained

[pboothe]

Rebased because the master branch updated. All tests passed, no merge conflicts. Merging now.