Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility to generate JSON schema #11

Merged
merged 1 commit into from
May 10, 2023

Conversation

robertodauria
Copy link
Contributor

@robertodauria robertodauria commented May 8, 2023

This change is Reviewable

@robertodauria robertodauria changed the base branch from sandbox-roberto-server to main May 8, 2023 15:41
@coveralls
Copy link

coveralls commented May 8, 2023

Pull Request Test Coverage Report for Build 4927525153

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.879%

Totals Coverage Status
Change from base Build 4916967426: 0.0%
Covered Lines: 547
Relevant Lines: 660

💛 - Coveralls

@robertodauria robertodauria marked this pull request as ready for review May 8, 2023 16:09
Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the commit history for this PR.

The changes in main.go lgtm, but commit history makes it look like more was going on than actually is.

Reviewable status: 0 of 1 approvals obtained

@robertodauria
Copy link
Contributor Author

@cristinaleonr I rebased this PR on main as Stephen asked but he is out this week, would you be willing to take a look? Thanks.

Copy link
Contributor

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @stephen-soltesz)

@robertodauria robertodauria merged commit 4762869 into main May 10, 2023
@robertodauria robertodauria deleted the sandbox-roberto-generate-schema branch May 10, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants